Review main Merged Breaking

64600[!!!][TASK] Remove cHash options from UriBuilders, ViewHelper + Routing

Benni Mack CR +2 V +2 Hard +18 −287 updated 05/29/20, 19:33

Commit message

The cHash options in ViewHelpers and UriBuilders were a no-op
in TYPO3 v10 and Site Handling, and triggered deprecations.

They can now be removed without any side-effects, as cHash generation
is solely coordinated with the PageRouter and resolving is done within
1 PSR-15 middleware.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 2

Files 15

Review log 610

  1. Benni Mack uploaded patch set 1 05/29/20, 12:11

  2. TYPO3com voted on patch set 1 V +1 05/29/20, 12:42 Completed build in 23m 45s on Fri, 29 May, 12:42 PM Test Summary: 73052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3630

  3. Benni Mack updated the commit message in patch set 2 05/29/20, 15:20

  4. TYPO3com voted on patch set 2 V -1 05/29/20, 15:35 Completed build in 15m 28s on Fri, 29 May, 03:35 PM Test Summary: 72539 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3634

  5. TYPO3com voted on patch set 2 V +1 05/29/20, 15:48 Completed build in 43m 50s on Fri, 29 May, 03:48 PM Test Summary: 73052 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3634

  6. Benni Mack uploaded patch set 3 05/29/20, 18:31

  7. Wouter Wolters voted on patch set 3 V +1 CR +1 05/29/20, 18:41

  8. TYPO3com voted on patch set 3 V +1 05/29/20, 18:47 Completed build in 15m 58s on Fri, 29 May, 06:47 PM Test Summary: 73073 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3642

  9. Anja Leichsenring voted on patch set 3 V +2 CR +2 05/29/20, 19:33

  10. Anja Leichsenring merged patch set 4 05/29/20, 19:33