Review main Merged Breaking

64603[!!!][TASK] Remove support for deprecated CLI command configuration

Benjamin Franzke CR +2 V +2 Hard +29 −583 updated 05/31/20, 06:37

Commit message

Configuration via Commands.php had been superseded by tag based
DI service configuration which allowed to configure DI and dependencies
for CLI commands in one place.

The CommandRegistry is refactored as the runtime merging logic
can now be dropped and handled in addLazyCommand – which is called
by the symfony DI generated factory – instead.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 3

Files 11

Review log 913

  1. Benjamin Franzke uploaded patch set 1 05/29/20, 19:32

  2. TYPO3com voted on patch set 1 V +1 05/29/20, 19:43 Completed build in 11m 03s on Fri, 29 May, 07:43 PM Test Summary: 73067 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3652

  3. Benjamin Franzke updated the commit message in patch set 2 05/29/20, 19:47

  4. TYPO3com voted on patch set 2 V +1 05/29/20, 19:59 Completed build in 12m 29s on Fri, 29 May, 07:59 PM Test Summary: 73045 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3654

  5. Wouter Wolters voted on patch set 2 CR +1 05/29/20, 20:21

  6. Benni Mack commented on patch set 2 05/29/20, 22:14

    CommandRequestHandler.php:36 Unresolved

    let's remove this handle as well in this patch
  7. Benni Mack uploaded patch set 3 05/30/20, 18:43

  8. Benni Mack uploaded patch set 4 05/30/20, 18:43

  9. Benni Mack voted on patch set 4 V +1 CR +1 05/30/20, 18:44

  10. TYPO3com voted on patch set 3 V +1 05/30/20, 18:54 Completed build in 11m 11s on Sat, 30 May, 06:54 PM Test Summary: 72980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3702

  11. TYPO3com voted on patch set 4 V +1 05/30/20, 18:59 Completed build in 16m 01s on Sat, 30 May, 06:59 PM Test Summary: 72980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3703

  12. Andreas Kienast voted on patch set 4 V +2 CR +2 05/31/20, 06:37

  13. Andreas Kienast merged patch set 5 05/31/20, 06:37