Review main Merged Breaking

64604[!!!][TASK] Remove deprecated TSFE code superseded by AssetCollector

Benni Mack CR +2 V +2 Easy +0 −44 updated 05/29/20, 22:16

Commit message

AssetCollector takes over logic that was previously built in TSFE, to decouple
more functionality from TSFE going more into the direction of SRP.

* TSFE->lastImageInfo
* TSFE->imagesOnPage

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 912

  1. Benni Mack uploaded patch set 1 05/29/20, 20:11

  2. Oliver Klee commented on patch set 1 05/29/20, 20:22

    ContentObjectRenderer.php:1077 Unresolved

    I think this comments need to go away as well.

    ImageContentObject.php:80 Unresolved

    Ditto.
  3. Benni Mack commented on patch set 1 CR -1 05/29/20, 20:24

    on it
  4. Benni Mack uploaded patch set 2 05/29/20, 20:25

  5. Benni Mack uploaded patch set 3 05/29/20, 20:27

  6. Wouter Wolters voted on patch set 3 CR +1 05/29/20, 20:27

  7. Wouter Wolters voted on patch set 3 V +1 05/29/20, 20:35

  8. TYPO3com voted on patch set 1 V -1 05/29/20, 20:41 Completed build in 19m 11s on Fri, 29 May, 08:41 PM Test Summary: 73073 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3660

  9. TYPO3com voted on patch set 2 V -1 05/29/20, 20:58 Completed build in 19m 43s on Fri, 29 May, 08:58 PM Test Summary: 73072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3662

  10. TYPO3com voted on patch set 3 V +1 05/29/20, 21:03 Completed build in 24m 43s on Fri, 29 May, 09:03 PM Test Summary: 73073 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3663

  11. Benni Mack voted on patch set 3 V +2 CR +2 05/29/20, 22:16

  12. Benni Mack merged patch set 4 05/29/20, 22:16