Review main Merged Breaking

64605[!!!][TASK] Remove deprecated functionality in ContentObjectRenderer

Wouter Wolters CR +2 V +2 Hard +33 −609 updated 05/30/20, 07:50

Commit message

All deprecated code within ContentObjectRenderer is removed.

This also includes hooks

* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['cObjTypeAndClassDefault']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['cObjTypeAndClass']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['extLinkATagParamsHandler']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['typolinkLinkHandler']

and TypoScript options:
* typolink.addQueryString.method = POST
* typolink.addQueryString.method = POST,GET
* typolink.addQueryString.method = GET,POST

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 9

Review log 812

  1. Wouter Wolters uploaded patch set 1 05/29/20, 20:29

  2. TYPO3com voted on patch set 1 V -1 05/29/20, 20:39 Completed build in 44s on Fri, 29 May, 08:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3665

  3. Benni Mack uploaded patch set 2 05/29/20, 20:50

  4. TYPO3com voted on patch set 2 V -1 05/29/20, 21:21 Completed build in 23m 39s on Fri, 29 May, 09:21 PM Test Summary: 18 of 73542 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3666

  5. Benni Mack uploaded patch set 3 05/29/20, 21:31

  6. TYPO3com voted on patch set 3 V +1 05/29/20, 21:44 Completed build in 12m 43s on Fri, 29 May, 09:44 PM Test Summary: 73033 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3670

  7. Benni Mack voted on patch set 3 V +1 CR +1 05/29/20, 21:47

  8. Benni Mack uploaded patch set 4 05/29/20, 22:17

  9. TYPO3com voted on patch set 4 V +1 05/29/20, 22:44 Completed build in 19m 30s on Fri, 29 May, 10:44 PM Test Summary: 73034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3679

  10. Benni Mack voted on patch set 4 V +1 CR +1 05/29/20, 22:56

  11. Anja Leichsenring voted on patch set 4 V +2 CR +2 05/30/20, 07:50

  12. Anja Leichsenring merged patch set 5 05/30/20, 07:50