Review 10.4 Merged

64608[TASK] Switch to json_encode for tx_cms_showpic parameters

Oliver Hader CR +2 V +2 Easy +9 −4 updated 05/30/20, 08:16

Commit message

Scalar values sent via HTTP query parameters to ShowImageController
are using `json_encode` instead of `unserialize`. The parameter
stream is still secured with an HMAC before being deserialized.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 05/29/20, 21:32

  2. TYPO3com voted on patch set 1 V +1 05/29/20, 21:47 Completed build in 14m 57s on Fri, 29 May, 09:47 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-9

  3. Oliver Hader voted on patch set 1 V +2 CR +2 05/30/20, 08:16

  4. Oliver Hader merged patch set 2 05/30/20, 08:16