Review 9.5 Merged

64609[TASK] Switch to json_encode for tx_cms_showpic parameters

Oliver Hader CR +2 V +2 Easy +9 −4 updated 05/30/20, 08:16

Commit message

Scalar values sent via HTTP query parameters to ShowImageController
are using `json_encode` instead of `unserialize`. The parameter
stream is still secured with an HMAC before being deserialized.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 35

  1. Oliver Hader uploaded patch set 1 05/29/20, 21:33

  2. TYPO3com voted on patch set 1 V -1 05/29/20, 22:09 Completed build in 30m 04s on Fri, 29 May, 10:09 PM Test Summary: 1 of 75566 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-669

  3. TYPO3com voted on patch set 1 V +1 05/30/20, 08:12 Completed build in 11h 03m 38s on Sat, 30 May, 08:12 AM Test Summary: 74965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-669

  4. Oliver Hader voted on patch set 1 V +2 CR +2 05/30/20, 08:16

  5. Oliver Hader merged patch set 2 05/30/20, 08:16