Review main Merged Breaking

64610[!!!][TASK] Remove deprecated class aliases

Wouter Wolters CR +2 V +2 Normal +9 −109 updated 06/22/20, 19:44

Commit message

The following class aliases are removed:

* `TYPO3\CMS\Frontend\Page\PageRepository`
* `TYPO3\CMS\Frontend\Page\PageRepositoryGetPageHookInterface`
* `TYPO3\CMS\Frontend\Page\PageRepositoryGetPageOverlayHookInterface`
* `TYPO3\CMS\Frontend\Page\PageRepositoryInitHookInterface`
* `TYPO3\CMS\Frontend\Page\PageRepositoryGetRecordOverlayHookInterface`
* `TYPO3\CMS\Lowlevel\Utility\ArrayBrowser`

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 811

  1. Wouter Wolters uploaded patch set 1 05/29/20, 21:37

  2. TYPO3com voted on patch set 1 V -1 05/29/20, 22:01 Completed build in 19m 43s on Fri, 29 May, 10:01 PM Test Summary: 3 of 73557 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3672

  3. Wouter Wolters uploaded patch set 2 05/30/20, 08:38

  4. TYPO3com voted on patch set 2 V +1 05/30/20, 08:54 Completed build in 16m 00s on Sat, 30 May, 08:54 AM Test Summary: 73034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3686

  5. Andreas Kienast uploaded patch set 3 05/30/20, 10:48

  6. Andreas Kienast voted on patch set 3 V +1 CR +1 05/30/20, 10:48

  7. TYPO3com voted on patch set 3 V +1 05/30/20, 11:03 Completed build in 14m 31s on Sat, 30 May, 11:03 AM Test Summary: 73034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3687

  8. Daniel Goerz voted on patch set 3 V +2 CR +2 05/30/20, 11:19

  9. Daniel Goerz merged patch set 4 05/30/20, 11:19

  10. Helmut Hummel commented on patch set 4 06/22/20, 10:24

    post -1

    composer.json:118

    Removing this will completely break non composer installations!
  11. Daniel Goerz commented on patch set 4 06/22/20, 19:44

    composer.json:118 Reply Unresolved