Review main Merged Breaking

64618[!!!][TASK] Remove sys_template.sitetitle DB field and logic

Benni Mack CR +2 V +2 Normal +19 −196 updated 08/04/20, 18:16

Commit message

The sys_template.sitetitle field has been deprecated in v10
and is superseded by title handling of site configuration.
The patch removes handling and db field.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 34

Show 14 more files

Review log 2029

Show 24 earlier messages
  1. Benni Mack uploaded patch set 1 05/30/20, 18:08

  2. TYPO3com voted on patch set 1 V -1 05/30/20, 18:40 Completed build in 32m 09s on Sat, 30 May, 06:40 PM Test Summary: 6770 of 73494 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3701

  3. Benni Mack uploaded patch set 2 06/01/20, 09:25

  4. TYPO3com voted on patch set 2 V -1 06/01/20, 09:54 Completed build in 29m 30s on Mon, 1 Jun, 09:54 AM Test Summary: 6758 of 73329 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3724

  1. Stephan Großberndt marked it work in progress 06/04/20, 08:49

  2. Christian Kuhn uploaded patch set 3 08/03/20, 18:54

  3. Christian Kuhn commented on patch set 3 08/03/20, 18:55

    rebased
  4. Christian Kuhn commented on patch set 3 08/03/20, 19:25

    ExtendedTemplateService.php:392 Unresolved

    ok to drop $depth === 'resources'? is this a *very old* left over from when ts template module did stuff with images?

    EnhancerSiteRequestTest.php:120

    this is not removed?
  5. TYPO3com voted on patch set 3 V -1 08/03/20, 19:26 Completed build in 32m 12s on Mon, 3 Aug, 07:26 PM Test Summary: 3084 of 73441 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4385

  6. Christian Kuhn commented on patch set 3 08/03/20, 20:00

    EnhancerSiteRequestTest.php:120 Reply Unresolved

    but it needs to be removed.
  7. Christian Kuhn uploaded patch set 4 08/03/20, 20:00

  8. Christian Kuhn uploaded patch set 5 08/03/20, 20:08

  9. TYPO3com voted on patch set 5 V -1 08/03/20, 20:22 Completed build in 13m 40s on Mon, 3 Aug, 08:22 PM Test Summary: 147 of 73441 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4387

  10. TYPO3com voted on patch set 4 V -1 08/03/20, 20:30 Completed build in 30m 00s on Mon, 3 Aug, 08:30 PM Test Summary: 1527 of 73441 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4386

  11. Christian Kuhn uploaded patch set 6 08/04/20, 08:58

  12. TYPO3com voted on patch set 6 V +1 08/04/20, 09:09 Completed build in 11m 24s on Tue, 4 Aug, 09:09 AM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4395

  13. Christian Kuhn uploaded patch set 7 08/04/20, 14:03

  14. Christian Kuhn updated the commit message in patch set 8 08/04/20, 14:11

  15. TYPO3com voted on patch set 7 V +1 08/04/20, 14:15 Completed build in 11m 27s on Tue, 4 Aug, 02:15 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4400

  16. TYPO3com voted on patch set 8 V +1 08/04/20, 14:22 Completed build in 11m 39s on Tue, 4 Aug, 02:22 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4401

  17. Christian Kuhn voted on patch set 8 V +1 CR +1 08/04/20, 14:23

  18. Benni Mack commented on patch set 8 08/04/20, 14:51

    This change is ready for review.
  19. Oliver Klee commented on patch set 8 CR -1 08/04/20, 15:41

    tsref.xml:3951

    We now have a surplus closing property tag.
  20. Christian Kuhn commented on patch set 8 V 0 CR -1 08/04/20, 16:45

    tsref.xml:3951 Reply Unresolved

    good catch!
  21. Christian Kuhn uploaded patch set 9 08/04/20, 16:46

  22. Christian Kuhn voted on patch set 9 V +1 CR +1 08/04/20, 16:46

  23. TYPO3com voted on patch set 9 V +1 08/04/20, 16:59 Completed build in 12m 43s on Tue, 4 Aug, 04:59 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4411

  24. Georg Ringer voted on patch set 9 V +2 CR +2 08/04/20, 17:28

  25. Benni Mack merged patch set 10 08/04/20, 18:16