64618[!!!][TASK] Remove sys_template.sitetitle DB field and logic
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 2
Files 34
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php1+1 −3
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+0 −16
- typo3/sysext/core/Documentation/Changelog/master/Breaking-91473-DeprecatedFunctionalityRemoved.rst+2 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Template/TemplateCest.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Frontend/JsonRenderer.typoscript+0 −3
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+3 −7
- typo3/sysext/frontend/Configuration/TCA/sys_template.php+1 −9
- typo3/sysext/frontend/Resources/Private/Language/locallang_csh_systmpl.xlf+0 −3
- typo3/sysext/frontend/Resources/Private/Language/locallang_tca.xlf+0 −3
- typo3/sysext/frontend/Tests/Functional/Rendering/TitleTagRenderingTest.php+7 −35
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/AbstractLocalizedPagesTestCase.php+0 −7
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGeneratorTest.php+0 −6
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequestTest.php2+0 −7
- typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php+0 −12
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+0 −22
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+0 −7
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+0 −22
- typo3/sysext/frontend/Tests/Functional/SiteHandling/TypoLinkGeneratorTest.php+0 −6
- typo3/sysext/frontend/Tests/Functional/Tca/TemplateVisibleFieldsTest.php+0 −1
- typo3/sysext/frontend/ext_tables.sql+0 −1
Show 14 more files
- typo3/sysext/install/Classes/Controller/InstallerController.php+0 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+1 −0
- typo3/sysext/t3editor/Resources/Private/tsref.xml2+0 −5
- typo3/sysext/t3editor/Resources/Public/JavaScript/Mode/typoscript/typoscript.js+0 −1
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerModuleFunctionController.php+0 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateConstantEditorModuleFunctionController.php+0 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+3 −5
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+0 −1
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_info.xlf+0 −3
- typo3/sysext/tstemplate/Resources/Private/Templates/ConstantEditor.html+0 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/InformationModule.html+0 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/PageZero.html+1 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateAnalyzerModuleFunction.html+0 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateObjectBrowserModuleFunction.html+0 −3
Review log 2029
Show 24 earlier messages
-
Benni Mack uploaded patch set 1 05/30/20, 18:08
-
TYPO3com voted on patch set 1 V -1 05/30/20, 18:40 Completed build in 32m 09s on Sat, 30 May, 06:40 PM Test Summary: 6770 of 73494 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3701
-
Benni Mack uploaded patch set 2 06/01/20, 09:25
-
TYPO3com voted on patch set 2 V -1 06/01/20, 09:54 Completed build in 29m 30s on Mon, 1 Jun, 09:54 AM Test Summary: 6758 of 73329 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3724
-
Stephan Großberndt marked it work in progress 06/04/20, 08:49
-
Christian Kuhn uploaded patch set 3 08/03/20, 18:54
-
Christian Kuhn commented on patch set 3 08/03/20, 18:55
rebased -
Christian Kuhn commented on patch set 3 08/03/20, 19:25
ExtendedTemplateService.php:392Unresolvedok to drop $depth === 'resources'? is this a *very old* left over from when ts template module did stuff with images?EnhancerSiteRequestTest.php:120this is not removed? -
TYPO3com voted on patch set 3 V -1 08/03/20, 19:26 Completed build in 32m 12s on Mon, 3 Aug, 07:26 PM Test Summary: 3084 of 73441 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4385
-
Christian Kuhn commented on patch set 3 08/03/20, 20:00
EnhancerSiteRequestTest.php:120Reply Unresolvedbut it needs to be removed. -
Christian Kuhn uploaded patch set 4 08/03/20, 20:00
-
Christian Kuhn uploaded patch set 5 08/03/20, 20:08
-
TYPO3com voted on patch set 5 V -1 08/03/20, 20:22 Completed build in 13m 40s on Mon, 3 Aug, 08:22 PM Test Summary: 147 of 73441 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4387
-
TYPO3com voted on patch set 4 V -1 08/03/20, 20:30 Completed build in 30m 00s on Mon, 3 Aug, 08:30 PM Test Summary: 1527 of 73441 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4386
-
Christian Kuhn uploaded patch set 6 08/04/20, 08:58
-
TYPO3com voted on patch set 6 V +1 08/04/20, 09:09 Completed build in 11m 24s on Tue, 4 Aug, 09:09 AM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4395
-
Christian Kuhn uploaded patch set 7 08/04/20, 14:03
-
Christian Kuhn updated the commit message in patch set 8 08/04/20, 14:11
-
TYPO3com voted on patch set 7 V +1 08/04/20, 14:15 Completed build in 11m 27s on Tue, 4 Aug, 02:15 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4400
-
TYPO3com voted on patch set 8 V +1 08/04/20, 14:22 Completed build in 11m 39s on Tue, 4 Aug, 02:22 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4401
-
Christian Kuhn voted on patch set 8 V +1 CR +1 08/04/20, 14:23
-
Benni Mack commented on patch set 8 08/04/20, 14:51
This change is ready for review. -
Oliver Klee commented on patch set 8 CR -1 08/04/20, 15:41
tsref.xml:3951We now have a surplus closing property tag. -
Christian Kuhn commented on patch set 8 V 0 CR -1 08/04/20, 16:45
tsref.xml:3951Reply Unresolvedgood catch! -
Christian Kuhn uploaded patch set 9 08/04/20, 16:46
-
Christian Kuhn voted on patch set 9 V +1 CR +1 08/04/20, 16:46
-
TYPO3com voted on patch set 9 V +1 08/04/20, 16:59 Completed build in 12m 43s on Tue, 4 Aug, 04:59 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4411
-
Georg Ringer voted on patch set 9 V +2 CR +2 08/04/20, 17:28
-
Benni Mack merged patch set 10 08/04/20, 18:16