Review main Merged

64620[BUGFIX] Show hidden records that are unhidden in workspace

Benni Mack CR +2 V +2 Easy +2 −0 updated 06/01/20, 17:56

Commit message

When a live record that is hidden, but gets unhidden in a
workspace version, the record should also be resolved within
move placeholder resolving.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Danilo Caccialanza +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Danilo Caccialanza +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 05/30/20, 21:17

  2. Benni Mack updated the commit message in patch set 2 05/30/20, 21:17

  3. TYPO3com voted on patch set 1 V +1 05/30/20, 21:30 Completed build in 12m 59s on Sat, 30 May, 09:30 PM Test Summary: 73007 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3709

  4. TYPO3com voted on patch set 2 V +1 05/30/20, 21:35 Completed build in 17m 22s on Sat, 30 May, 09:35 PM Test Summary: 73007 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3710

  5. Riccardo De Contardi commented on patch set 2 V +1 05/30/20, 22:53

    Verified with latest master 11.0.0-dev and the test on https://forge.typo3.org/issues/88054#note-4
  6. Danilo Caccialanza commented on patch set 2 V +1 CR +1 05/31/20, 17:37

    I tried the your patch on 10.4.3 and it works perfectly, for v10 can be relased. On 9.5.18 the patch it would seem not work.
  7. Frank Nägler voted on patch set 2 V +2 CR +2 06/01/20, 17:56

  8. Frank Nägler merged patch set 3 06/01/20, 17:56