64621[BUGFIX] Handle orphans in SlugHelper::isUniqueInSite
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 34
-
filigivuji filigivuji uploaded patch set 1 05/30/20, 22:28
-
TYPO3com voted on patch set 1 V -1 05/30/20, 22:29 Completed build in 21s on Sat, 30 May, 10:29 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3712
-
filigivuji filigivuji commented on patch set 1 05/30/20, 22:37
It seems the CI had a hiccup and should be rerun.SlugHelper.php:269UnresolvedNot completely sure whether removing this is correct, I couldn't find a called method in this function that declares throwing this exception though. I only later found out that this bug has already been fixed in master (https://review.typo3.org/c/Packages/TYPO3.CMS/+/61778/3/typo3/sysext/core/Classes/DataHandling/SlugHelper.php#309); the master change however did not remove this @throws declaration, so if removing it is correct, it should be applied to master as well. By the way isUniqueInTable and buildSlugForUniqueInTable also declare throwing SiteNotFoundException; this may have been a copy-and-paste mistake and one may want to remove it there too, especially in master.SlugHelper.php:363Unresolvedsee above comment about SiteNotFoundException -
filigivuji filigivuji abandoned the change 05/30/20, 22:44
Nevermind, I uploaded this against the wrong branch.