Review 9.5 Abandoned

64622[BUGFIX] Handle orphans in SlugHelper::isUniqueInSite

filigivuji filigivuji CR 0 V 0 Easy +7 −4 updated 10/03/21, 14:50

Commit message

Catch SiteNotFoundException when looking up a page's site and interpret
it as a unique site.
This can occur e.g. when a page is marked as deleted=0 but its parent
page as deleted=1.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 910

  1. filigivuji filigivuji uploaded patch set 1 05/30/20, 22:43

  2. filigivuji filigivuji commented on patch set 1 05/30/20, 22:45

    SlugHelper.php:269 Unresolved

    Not completely sure whether removing this is correct, I couldn't find a called method in this function that declares throwing this exception though. I only later found out that this bug has already been fixed in master (https://review.typo3.org/c/Packages/TYPO3.CMS/+/61778/3/typo3/sysext/core/Classes/DataHandling/SlugHelper.php#309); the master change however did not remove this @throws declaration, so if removing it is correct, it should be applied to master as well. By the way isUniqueInTable and buildSlugForUniqueInTable also declare throwing SiteNotFoundException; this may have been a copy-and-paste mistake and one may want to remove it there too, especially in master.

    SlugHelper.php:363 Unresolved

    see above comment about SiteNotFoundException
  3. TYPO3com voted on patch set 1 V +1 05/30/20, 22:55 Completed build in 11m 58s on Sat, 30 May, 10:55 PM Test Summary: 74965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-670

  4. Benni Mack commented on patch set 1 CR +1 06/04/20, 19:23

    Why should we fix this in v9.5 only and not in v10?
  5. filigivuji filigivuji commented on patch set 1 06/05/20, 14:48

    > Patch Set 1: Code-Review+1 > > Why should we fix this in v9.5 only and not in v10? I developed this bugfix on 9.5. Only when trying to rebase it on later branches (including 10.4) I noticed that this has been fixed there already, by you in fact: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61778 -- Though it's marked as "[TASK]" so not sure whether you knowingly fixed this. If you agree that deleting the @throws declarations is correct, I can upload a new change for this to master. Maybe someone with an IDE setup can check.
  6. Markus Gerdes commented on patch set 1 V +1 CR +1 10/05/20, 14:55

    struggled with this during update of a page in draft workspace, not belonging to any site so far. Like this patch to be in core as v10 seems to do the same.
  7. Anja Leichsenring commented on patch set 1 CR -1 11/11/20, 20:53

    can we please clean this up regarding open questions?
  8. filigivuji filigivuji commented on patch set 1 11/11/20, 21:04

    > Patch Set 1: Code-Review-1 > > can we please clean this up regarding open questions? Can you elaborate what you would like to see changed?
  9. Anja Leichsenring commented on patch set 1 11/11/20, 21:23

    > Patch Set 1: > > > Patch Set 1: Code-Review-1 > > > > can we please clean this up regarding open questions? > > Can you elaborate what you would like to see changed? the unresolved comments in the review. about throws annotation.
  10. Benni Mack abandoned the change 10/03/21, 14:50

    This change is abandoned as there is no upcoming free-of-charge 9.5 release anymore.