64622[BUGFIX] Handle orphans in SlugHelper::isUniqueInSite
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 910
-
filigivuji filigivuji uploaded patch set 1 05/30/20, 22:43
-
filigivuji filigivuji commented on patch set 1 05/30/20, 22:45
SlugHelper.php:363Unresolvedsee above comment about SiteNotFoundException -
TYPO3com voted on patch set 1 V +1 05/30/20, 22:55 Completed build in 11m 58s on Sat, 30 May, 10:55 PM Test Summary: 74965 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-670
-
Benni Mack commented on patch set 1 CR +1 06/04/20, 19:23
Why should we fix this in v9.5 only and not in v10? -
filigivuji filigivuji commented on patch set 1 06/05/20, 14:48
> Patch Set 1: Code-Review+1 > > Why should we fix this in v9.5 only and not in v10? I developed this bugfix on 9.5. Only when trying to rebase it on later branches (including 10.4) I noticed that this has been fixed there already, by you in fact: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61778 -- Though it's marked as "[TASK]" so not sure whether you knowingly fixed this. If you agree that deleting the @throws declarations is correct, I can upload a new change for this to master. Maybe someone with an IDE setup can check. -
Markus Gerdes commented on patch set 1 V +1 CR +1 10/05/20, 14:55
struggled with this during update of a page in draft workspace, not belonging to any site so far. Like this patch to be in core as v10 seems to do the same. -
Anja Leichsenring commented on patch set 1 CR -1 11/11/20, 20:53
can we please clean this up regarding open questions? -
filigivuji filigivuji commented on patch set 1 11/11/20, 21:04
> Patch Set 1: Code-Review-1 > > can we please clean this up regarding open questions? Can you elaborate what you would like to see changed? -
Anja Leichsenring commented on patch set 1 11/11/20, 21:23
> Patch Set 1: > > > Patch Set 1: Code-Review-1 > > > > can we please clean this up regarding open questions? > > Can you elaborate what you would like to see changed? the unresolved comments in the review. about throws annotation. -
Benni Mack abandoned the change 10/03/21, 14:50
This change is abandoned as there is no upcoming free-of-charge 9.5 release anymore.
SlugHelper.php:269Unresolved