Review main Merged

64624[TASK] Switch to json_encode for file folder tree

Oliver Hader CR +2 V +2 Easy +2 −2 updated 06/02/20, 05:10

Commit message

Scalar values sent via HTTP query parameters to
FileSystemNavigationFrameController are using `json_encode` instead
of `unserialize`. The parameter stream is still secured with an HMAC
before being deserialized.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Oliver Hader uploaded patch set 1 05/31/20, 07:23

  2. TYPO3com voted on patch set 1 V +1 05/31/20, 07:37 Completed build in 13m 29s on Sun, 31 May, 07:36 AM Test Summary: 72979 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3718

  3. Oliver Klee voted on patch set 1 CR +1 05/31/20, 09:59

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 05/31/20, 12:15

  5. Frank Nägler voted on patch set 1 V +1 CR +1 06/01/20, 18:08

  6. Andreas Kienast commented on patch set 1 V +2 CR +2 06/02/20, 05:10

    wow
  7. Andreas Kienast merged patch set 2 06/02/20, 05:10