Review 10.4 Merged

64625[TASK] Switch to json_encode for file folder tree

Oliver Hader CR +2 V +2 Easy +2 −2 updated 06/02/20, 05:23

Commit message

Scalar values sent via HTTP query parameters to
FileSystemNavigationFrameController are using `json_encode` instead
of `unserialize`. The parameter stream is still secured with an HMAC
before being deserialized.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Oliver Hader uploaded patch set 1 05/31/20, 07:23

  2. TYPO3com voted on patch set 1 V +1 05/31/20, 07:38 Completed build in 15m 06s on Sun, 31 May, 07:38 AM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-13

  3. Oliver Klee voted on patch set 1 CR +1 05/31/20, 10:00

  4. Andreas Kienast uploaded patch set 2 06/02/20, 05:10

  5. Andreas Kienast voted on patch set 2 V +2 CR +2 06/02/20, 05:19

  6. TYPO3com voted on patch set 2 V +1 06/02/20, 05:22 Completed build in 11m 20s on Tue, 2 Jun, 05:22 AM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-16

  7. Andreas Kienast merged patch set 3 06/02/20, 05:23