Review 10.4 Merged

64627[TASK] Reduce inline JavaScript in ext:setup

Oliver Hader CR +2 V +2 Hard +414 −68 updated 05/31/20, 08:15

Commit message

This change aims to reduce the amount of inline JavaScript by
removing `onchange` or `onclick` events and dynamically created
JavaScript code/settings.

* moves inline JavaScript for avatar handling to new SetupModule
* avoids using configuration options `onClick`, `onClickLabels`
  and `confirmData.jsCodeAfterOk` which contain inline JavaScript
* introduces configuration options `conformationData.eventName`
  and `clickData.eventName` to substitute mentioned deprecations
* adds PSR-14 `AddJavaScriptModulesEvent` which allows to apply
  custom RequireJS modules to handle mentioned new custom events

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 45

  1. Oliver Hader uploaded patch set 1 05/31/20, 07:53

  2. Oliver Hader wrote 05/31/20, 07:53

    Topic set to inline-javascript
  3. TYPO3com voted on patch set 1 V +1 05/31/20, 08:06 Completed build in 12m 40s on Sun, 31 May, 08:06 AM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-14

  4. Oliver Hader voted on patch set 1 V +2 CR +2 05/31/20, 08:15

  5. Oliver Hader merged patch set 2 05/31/20, 08:15