Review main Merged

64628[BUGFIX] Search for site root only in default language pages

Christian Toffolo CR +2 V +2 Easy +2 −1 updated 06/05/20, 12:14

Commit message

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Tomas Norre Mikkelsen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Christian Toffolo uploaded patch set 1 06/01/20, 09:27

  2. TYPO3com voted on patch set 1 V +1 06/01/20, 09:42 Completed build in 14m 43s on Mon, 1 Jun, 09:42 AM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3725

  3. Jonas Eberle commented on patch set 1 06/01/20, 18:23

    BackendConfigurationManager.php:176 Unresolved

    sys_language_uid=-1 would be valid as well
  4. Christian Toffolo uploaded patch set 2 06/01/20, 22:04

  5. TYPO3com voted on patch set 2 V +1 06/01/20, 22:22 Completed build in 18m 33s on Mon, 1 Jun, 10:22 PM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3736

  6. Benni Mack commented on patch set 3 06/04/20, 19:13

    Published edit on patch set 2.
  7. Benni Mack commented on patch set 3 V +1 CR +1 06/04/20, 19:14

    @Christian: pages can't have language=-1 so I adapted the change!
  8. Jonas Eberle voted on patch set 3 V +1 06/04/20, 19:17

  9. TYPO3com voted on patch set 3 V +1 06/04/20, 19:49 Completed build in 29m 46s on Thu, 4 Jun, 07:49 PM Test Summary: 72828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3836

  10. Tomas Norre Mikkelsen voted on patch set 3 CR +1 06/05/20, 08:18

  11. Benni Mack voted on patch set 3 V +2 CR +2 06/05/20, 12:14

  12. Benni Mack merged patch set 4 06/05/20, 12:14