64631[!!!][TASK] Remove XML-based label parsing
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- TYPO3com +1 CI
Issues 2
Files 51
- typo3/sysext/core/Classes/Localization/Parser/LocallangXmlParser.phpdeleted+0 −199
- typo3/sysext/core/Classes/Localization/LanguageStore.php+1 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+1 −1
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −2
- typo3/sysext/core/Documentation/Changelog/master/Breaking-91473-DeprecatedFunctionalityRemoved.rst+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/FlexForms/tt_content_flexform.xml+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/Overrides/pages.php+3 −3
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/Overrides/tt_content.php+4 −4
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_hotel.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_offer.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_price.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_hotel.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_offer.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_price.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel_offer_rel.php+6 −6
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_offer.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_price.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel_offer_rel.php+12 −12
Show 31 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_offer.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_hotel.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_offer.php+6 −6
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_price.php+6 −6
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel_rel.php+5 −5
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Resources/Private/Language/locallang_db.xlfnew+166 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Resources/Private/Language/locallang_db.xmldeleted+0 −67
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/Configuration/TCA/tx_testdatahandler_element.php+2 −2
- typo3/sysext/core/Tests/UnitDeprecated/Localization/Parser/Fixtures/locallang.xmldeleted+0 −20
- typo3/sysext/core/Tests/UnitDeprecated/Localization/Parser/Fixtures/locallangNumericKeys.xmldeleted+0 −23
- typo3/sysext/core/Tests/UnitDeprecated/Localization/Parser/Fixtures/locallangOnlyDefaultLanguage.xmldeleted+0 −14
- typo3/sysext/core/Tests/UnitDeprecated/Localization/Parser/Fixtures/locallang_override.xmldeleted+0 −18
- typo3/sysext/core/Tests/UnitDeprecated/Localization/Parser/LocallangXmlParserTest.phpdeleted+0 −196
- typo3/sysext/core/Tests/UnitDeprecated/Localization/LocalizationFactoryTest.phpdeleted+0 −84
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/Overrides/fe_users.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_blog.php+7 −7
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_comment.php+5 −5
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_dateexample.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_info.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_person.php+6 −6
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_post.php+14 −14
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_tag.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_csh.xlfnew+17 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_csh.xmldeleted+0 −15
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xlfnew+140 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xmldeleted+0 −55
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.php+1 −1
- typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+1 −0
Review log 1522
-
Benni Mack uploaded patch set 1 06/01/20, 19:02
-
TYPO3com voted on patch set 1 V +1 06/01/20, 19:14 Completed build in 12m 23s on Mon, 1 Jun, 07:14 PM Test Summary: 72812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3735
-
Benni Mack uploaded patch set 2 06/02/20, 11:41
-
TYPO3com voted on patch set 2 V +1 06/02/20, 11:52 Completed build in 10m 26s on Tue, 2 Jun, 11:52 AM Test Summary: 72812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3742
-
Benni Mack commented on patch set 3 06/02/20, 16:09
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V +1 06/02/20, 16:22 Completed build in 12m 14s on Tue, 2 Jun, 04:22 PM Test Summary: 72812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3748
-
Georg Ringer voted on patch set 3 V +1 CR +1 06/03/20, 11:14
-
Benjamin Franzke uploaded patch set 4 06/03/20, 11:38
-
Benjamin Franzke commented on patch set 4 06/03/20, 11:40
Should we also remove <T3locallang> fixtures from functional tests? See: $ git grep -l T3locallang typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Resources/Private/Language/locallang_db.xml typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_csh.xml typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xml -
Benjamin Franzke uploaded patch set 5 06/03/20, 11:47
-
TYPO3com voted on patch set 4 V +1 06/03/20, 11:51 Completed build in 12m 30s on Wed, 3 Jun, 11:51 AM Test Summary: 72806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3773
-
TYPO3com voted on patch set 5 V +1 06/03/20, 11:59 Completed build in 11m 58s on Wed, 3 Jun, 11:59 AM Test Summary: 72806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3774
-
Benni Mack commented on patch set 5 06/03/20, 13:53
> Patch Set 4: > > Should we also remove <T3locallang> fixtures from functional tests? > > See: > $ git grep -l T3locallang > typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Resources/Private/Language/locallang_db.xml > typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_csh.xml > typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xml yeah, good idea! -
Benjamin Franzke uploaded patch set 6 06/03/20, 13:58
-
Benjamin Franzke commented on patch set 6 CR -1 06/03/20, 14:04
> Should we also remove <T3locallang> fixtures from functional tests? For further reference/review, migrated those via regex-replace in vim: :%s/<label index="\([^"]*\)">\([^<]*\)<\/label>/<trans-unit id="\1" resname="\1">^M<source>\2<\/source>^M<\/trans-unit>/g But I forgot to adapt the TCA to point to .xlf instead of .xml. For some reasons the labels still worked when installing the fixture extension :confused: Still, CR -1 for now. -
TYPO3com voted on patch set 6 V +1 06/03/20, 14:10 Completed build in 11m 40s on Wed, 3 Jun, 02:10 PM Test Summary: 72804 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3776
-
Benjamin Franzke uploaded patch set 7 06/03/20, 14:12
-
Benni Mack commented on patch set 7 06/03/20, 14:17
Thanks for handling this @bnf -
TYPO3com voted on patch set 7 V +1 06/03/20, 14:23 Completed build in 11m 22s on Wed, 3 Jun, 02:23 PM Test Summary: 72805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3777
-
Andreas Kienast voted on patch set 7 V +2 CR +2 06/05/20, 12:25
-
Andreas Kienast merged patch set 8 06/05/20, 12:25
-
Tymoteusz Motylewski commented on patch set 8 06/07/20, 09:44
It would be nice to mention here or in deprecation rst how to migrate the labels eg that there are tools like : https://github.com/evoWeb/ew_llxml2xliff