Review main Merged Breaking

64631[!!!][TASK] Remove XML-based label parsing

Benni Mack CR +2 V +2 Expert +481 −847 updated 06/07/20, 09:44

Commit message

This leaves TYPO3 to only handle "XLF" files for language labels
natively.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 2

Files 51

Show 31 more files

Review log 1522

  1. Benni Mack uploaded patch set 1 06/01/20, 19:02

  2. TYPO3com voted on patch set 1 V +1 06/01/20, 19:14 Completed build in 12m 23s on Mon, 1 Jun, 07:14 PM Test Summary: 72812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3735

  3. Benni Mack uploaded patch set 2 06/02/20, 11:41

  4. TYPO3com voted on patch set 2 V +1 06/02/20, 11:52 Completed build in 10m 26s on Tue, 2 Jun, 11:52 AM Test Summary: 72812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3742

  5. Benni Mack commented on patch set 3 06/02/20, 16:09

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V +1 06/02/20, 16:22 Completed build in 12m 14s on Tue, 2 Jun, 04:22 PM Test Summary: 72812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3748

  7. Georg Ringer voted on patch set 3 V +1 CR +1 06/03/20, 11:14

  8. Benjamin Franzke uploaded patch set 4 06/03/20, 11:38

  9. Benjamin Franzke commented on patch set 4 06/03/20, 11:40

    Should we also remove <T3locallang> fixtures from functional tests? See: $ git grep -l T3locallang typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Resources/Private/Language/locallang_db.xml typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_csh.xml typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xml
  10. Benjamin Franzke uploaded patch set 5 06/03/20, 11:47

  11. TYPO3com voted on patch set 4 V +1 06/03/20, 11:51 Completed build in 12m 30s on Wed, 3 Jun, 11:51 AM Test Summary: 72806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3773

  12. TYPO3com voted on patch set 5 V +1 06/03/20, 11:59 Completed build in 11m 58s on Wed, 3 Jun, 11:59 AM Test Summary: 72806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3774

  13. Benni Mack commented on patch set 5 06/03/20, 13:53

    > Patch Set 4: > > Should we also remove <T3locallang> fixtures from functional tests? > > See: > $ git grep -l T3locallang > typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Resources/Private/Language/locallang_db.xml > typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_csh.xml > typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xml yeah, good idea!
  14. Benjamin Franzke uploaded patch set 6 06/03/20, 13:58

  15. Benjamin Franzke commented on patch set 6 CR -1 06/03/20, 14:04

    > Should we also remove <T3locallang> fixtures from functional tests? For further reference/review, migrated those via regex-replace in vim: :%s/<label index="\([^"]*\)">\([^<]*\)<\/label>/<trans-unit id="\1" resname="\1">^M<source>\2<\/source>^M<\/trans-unit>/g But I forgot to adapt the TCA to point to .xlf instead of .xml. For some reasons the labels still worked when installing the fixture extension :confused: Still, CR -1 for now.
  16. TYPO3com voted on patch set 6 V +1 06/03/20, 14:10 Completed build in 11m 40s on Wed, 3 Jun, 02:10 PM Test Summary: 72804 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3776

  17. Benjamin Franzke uploaded patch set 7 06/03/20, 14:12

  18. Benni Mack commented on patch set 7 06/03/20, 14:17

    Thanks for handling this @bnf
  19. TYPO3com voted on patch set 7 V +1 06/03/20, 14:23 Completed build in 11m 22s on Wed, 3 Jun, 02:23 PM Test Summary: 72805 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3777

  20. Andreas Kienast voted on patch set 7 V +2 CR +2 06/05/20, 12:25

  21. Andreas Kienast merged patch set 8 06/05/20, 12:25

  22. Tymoteusz Motylewski commented on patch set 8 06/07/20, 09:44

    It would be nice to mention here or in deprecation rst how to migrate the labels eg that there are tools like : https://github.com/evoWeb/ew_llxml2xliff