Review 10.4 Merged

64633[TASK] Avoid usages of TYPO3_MODE

Benjamin Franzke CR +2 V +2 Normal +62 −22 updated 06/02/20, 17:05

Commit message

All code that is using the constant TYPO3_MODE is hard to test,
as this needs to be encapsulated into various places. All testing framework
places run with TYPO3_MODE=FE which makes it impossible to even
consider making parts of the testing framework compatible running a pure
Frontend-based request in the future.

On top, the constant covers up cross-dependency between core dependencies
(whereas $GLOBALS[TSFE]->fe_user is actually a dependency to EXT:frontend).

Another testing-helper in Extbase's EnvironmentService allows to switch
within Extbase to simulate Frontend behaviour.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 46

  1. Benjamin Franzke commented on patch set 1 06/02/20, 14:37

    Cherry Picked from branch master.
  2. Benni Mack voted on patch set 1 V +1 CR +1 06/02/20, 14:45

  3. TYPO3com voted on patch set 1 V -1 06/02/20, 14:48 Completed build in 11m 05s on Tue, 2 Jun, 02:48 PM Test Summary: 1 of 74302 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-17

  4. TYPO3com voted on patch set 1 V +1 06/02/20, 16:05 Completed build in 1h 38m 37s on Tue, 2 Jun, 04:05 PM Test Summary: 73817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-17

  5. Benni Mack voted on patch set 1 V +2 CR +2 06/02/20, 17:05

  6. Benni Mack merged patch set 2 06/02/20, 17:05