Review 10.4 Merged

64635[BUGFIX] Avoid additional SQL query in slug lookup for pages

Benni Mack CR +2 V +2 Easy +1 −1 updated 06/03/20, 07:40

Commit message

PageRepository->fixVersioningPid() needs "t3ver_wsid" and "t3ver_oid"
to resolve a version, otherwise previewing in workspace context takes
another SQL query per page slug candidate.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 06/03/20, 07:21

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 06/03/20, 07:33 Completed build in 11m 16s on Wed, 3 Jun, 07:33 AM Test Summary: 73817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-19

  3. Benni Mack voted on patch set 1 V +2 CR +2 06/03/20, 07:40

  4. Benni Mack merged patch set 2 06/03/20, 07:40