64653[BUGFIX] Only render title attribute when given in image
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Markus Klein +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 2
Files 1
Review log 1014
-
Benni Mack uploaded patch set 1 06/02/20, 12:50
-
TYPO3com voted on patch set 1 V -1 06/02/20, 13:01 Completed build in 10m 55s on Tue, 2 Jun, 01:01 PM Test Summary: 12 of 73329 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3744
-
Benni Mack uploaded patch set 2 06/02/20, 13:21
-
TYPO3com voted on patch set 2 V +1 06/02/20, 13:32 Completed build in 10m 37s on Tue, 2 Jun, 01:32 PM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3745
-
Markus Klein commented on patch set 2 06/02/20, 16:03
I would prefer links to our own git-server/gerrit than "any" mirror. But not sure about the diff-view of course. -
Benni Mack commented on patch set 2 06/02/20, 16:04
Reply Unresolved
yeah, I basically copied this from the issue description -
Markus Klein commented on patch set 2 CR -1 06/02/20, 16:04
ImageViewHelper.php:203Unresolvedwhile being an edge-case the title "0" should be allowed. lets change to $title !== '' -
Benni Mack commented on patch set 3 06/02/20, 16:14
Published edit on patch set 2. -
Benni Mack updated the commit message in patch set 4 06/02/20, 16:14
-
Markus Klein voted on patch set 4 V +1 CR +1 06/02/20, 16:17
-
TYPO3com voted on patch set 3 V +1 06/02/20, 16:28 Completed build in 14m 31s on Tue, 2 Jun, 04:28 PM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3749
-
TYPO3com voted on patch set 4 V +1 06/02/20, 16:32 Completed build in 14m 07s on Tue, 2 Jun, 04:32 PM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3750
-
Anja Leichsenring voted on patch set 4 V +2 CR +2 06/02/20, 16:48
-
Anja Leichsenring merged patch set 5 06/02/20, 16:48