Review main Merged

64653[BUGFIX] Only render title attribute when given in image

Benni Mack CR +2 V +2 Easy +3 −2 updated 06/02/20, 16:48

Commit message

In change https://git.typo3.org/Packages/TYPO3.CMS.git/commit/e6e40cd214acc8581729ef9f6e98c5d9324ec11c
of bugfix #90656 the title attribute of the result was changed
to always be added, which should only be added when the
title is not empty.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1014

  1. Benni Mack uploaded patch set 1 06/02/20, 12:50

  2. TYPO3com voted on patch set 1 V -1 06/02/20, 13:01 Completed build in 10m 55s on Tue, 2 Jun, 01:01 PM Test Summary: 12 of 73329 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3744

  3. Benni Mack uploaded patch set 2 06/02/20, 13:21

  4. TYPO3com voted on patch set 2 V +1 06/02/20, 13:32 Completed build in 10m 37s on Tue, 2 Jun, 01:32 PM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3745

  5. Markus Klein commented on patch set 2 06/02/20, 16:03

    I would prefer links to our own git-server/gerrit than "any" mirror. But not sure about the diff-view of course.
  6. Benni Mack commented on patch set 2 06/02/20, 16:04

    Reply Unresolved

    yeah, I basically copied this from the issue description
  7. Markus Klein commented on patch set 2 CR -1 06/02/20, 16:04

    ImageViewHelper.php:203 Unresolved

    while being an edge-case the title "0" should be allowed. lets change to $title !== ''
  8. Benni Mack commented on patch set 3 06/02/20, 16:14

    Published edit on patch set 2.
  9. Benni Mack updated the commit message in patch set 4 06/02/20, 16:14

  10. Markus Klein voted on patch set 4 V +1 CR +1 06/02/20, 16:17

  11. TYPO3com voted on patch set 3 V +1 06/02/20, 16:28 Completed build in 14m 31s on Tue, 2 Jun, 04:28 PM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3749

  12. TYPO3com voted on patch set 4 V +1 06/02/20, 16:32 Completed build in 14m 07s on Tue, 2 Jun, 04:32 PM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3750

  13. Anja Leichsenring voted on patch set 4 V +2 CR +2 06/02/20, 16:48

  14. Anja Leichsenring merged patch set 5 06/02/20, 16:48