Review main Merged

64654[BUGFIX] Ensure only empty route requirements for aspects are defined

Oliver Hader CR +2 V +2 Normal +101 −46 updated 06/17/20, 09:32

Commit message

Overriding route requirements with `.+` allows to have slashes in route
parameters. This is different to Symfony's default behavior not allowing
slashes here at all.

However, when having multiple route parameters it can lead to resolving
false-positive routes like shown in the following example:

    routePath: '{first}/{second}'
    URI: https://example.com/first/second/third
    resolves to parameters
    + first: 'first/second'
    + second: 'third'

This change passes existing TYPO3 route `requirements` and uses pattern
`.+` only for those parameters not having a definition - both applies to
parameters using `aspects` only.

Besides that tests in `EnhancerLinkGeneratorTest` mixed internal argument
values with URL parameters (`100` <=> `hundred`) are were "wrong" before.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Manuel Selbach +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stephan Großberndt +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1418

  1. Oliver Hader uploaded patch set 1 06/02/20, 15:06

  2. TYPO3com voted on patch set 1 V -1 06/02/20, 15:18 Completed build in 12m 00s on Tue, 2 Jun, 03:18 PM Test Summary: 36 of 73329 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3746

  3. Oliver Hader uploaded patch set 2 06/04/20, 11:26

  4. Oliver Hader uploaded patch set 3 06/04/20, 11:30

  5. TYPO3com voted on patch set 2 V +1 06/04/20, 11:38 Completed build in 12m 17s on Thu, 4 Jun, 11:38 AM Test Summary: 72872 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3814

  6. TYPO3com voted on patch set 3 V +1 06/04/20, 11:44 Completed build in 13m 43s on Thu, 4 Jun, 11:44 AM Test Summary: 72872 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3815

  7. Benni Mack voted on patch set 3 V +1 CR +1 06/04/20, 19:10

  8. Stephan Großberndt updated the commit message in patch set 4 06/08/20, 07:53

  9. Stephan Großberndt commented on patch set 4 06/08/20, 07:55

    "Besides that tests in `EnhancerLinkGeneratorTest` mixed internal argument values with URL parameters (`100` <=> `hundred`) are were "wrong" before." should be "`EnhancerLinkGeneratorTest` no longer mixes internal argument values with URL parameters (`100` <=> `hundred`)" (or at least not end with 'are were "wrong" before')?
  10. Stephan Großberndt voted on patch set 4 V +1 06/08/20, 08:04

  11. TYPO3com voted on patch set 4 V +1 06/08/20, 08:06 Completed build in 12m 49s on Mon, 8 Jun, 08:06 AM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3881

  12. Benni Mack voted on patch set 4 V +1 CR +1 06/08/20, 09:41

  13. Stephan Großberndt commented on patch set 4 06/08/20, 09:42

    I have issues with 404 on news detail pages now. investigating
  14. Stephan Großberndt commented on patch set 4 06/08/20, 10:47

  15. Manuel Selbach voted on patch set 4 CR +1 06/09/20, 05:51

  16. Oliver Hader voted on patch set 4 V +2 CR +2 06/09/20, 07:28

  17. Oliver Hader merged patch set 5 06/09/20, 07:29

  18. Oliver Hader commented on patch set 5 06/17/20, 09:32

    AbstractEnhancer.php:61 Unresolved

    Removing this section causes a regression as mentioned in issue #91633