Review main Merged

64656[BUGFIX] Cast meta tag values to string in generateMetaTagHtml

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 06/03/20, 08:27

Commit message

It is possible for values returned by stdWrap to be of type int.
RequestHandler->generateMetaTagHtml() expects meta tag values to be
of type string. In order to avoid php errors, return values are now
casted to strings.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Nikita Hovratov uploaded patch set 1 06/02/20, 17:10

  2. Nikita Hovratov updated the commit message in patch set 2 06/02/20, 17:11

  3. TYPO3com voted on patch set 1 V +1 06/02/20, 17:22 Completed build in 12m 09s on Tue, 2 Jun, 05:22 PM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3752

  4. TYPO3com voted on patch set 2 V +1 06/02/20, 17:28 Completed build in 16m 31s on Tue, 2 Jun, 05:28 PM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3753

  5. Benni Mack voted on patch set 2 V +2 CR +2 06/03/20, 08:27

  6. Benni Mack merged patch set 3 06/03/20, 08:27