Review main Merged

64657[BUGFIX] Avoid additional SQL query in slug lookup for pages

Benni Mack CR +2 V +2 Easy +1 −1 updated 06/03/20, 07:21

Commit message

PageRepository->fixVersioningPid() needs "t3ver_wsid" and "t3ver_oid"
to resolve a version, otherwise previewing in workspace context takes
another SQL query per page slug candidate.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 06/02/20, 17:16

  2. TYPO3com voted on patch set 1 V +1 06/02/20, 17:33 Completed build in 14m 30s on Tue, 2 Jun, 05:33 PM Test Summary: 72842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3754

  3. Oliver Hader voted on patch set 1 CR +1 06/02/20, 17:57

  4. Markus Klein commented on patch set 1 V +1 CR +1 06/02/20, 18:20

    giving v+1 even though I did not test the actual use case, but adding two fields to an SQL select should not be breaking anything
  5. Benni Mack voted on patch set 1 V +2 CR +2 06/03/20, 07:21

  6. Benni Mack merged patch set 2 06/03/20, 07:21