Review main Abandoned

64658[BUGFIX] Avoid using "endtime" to be used with SQL OR() without braces

Benni Mack CR 0 V 0 Normal +183 −10 updated 11/10/21, 21:19

Commit message

When using a TCA table without deleted, or any other enablefields except
"endtime", then the SQL query is built in a wrong fashion both in PageRepository
and BackendUtility.

The fix adds a manual "()" around the orX() comparisons.

As we don't know what people use with such use cases, we aim
for fix this in master only.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 1727

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 06/02/20, 17:47

  2. TYPO3com voted on patch set 1 V -1 06/02/20, 17:59 Completed build in 11m 47s on Tue, 2 Jun, 05:59 PM Test Summary: 3 of 73365 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3755

  1. Markus Klein commented on patch set 1 06/02/20, 18:22

    PageRepository.php:1318 Unresolved

    IMO we need this here too?
  2. Oliver Hader uploaded patch set 2 06/02/20, 22:07

  3. TYPO3com voted on patch set 2 V -1 06/02/20, 22:08 Completed build in 29s on Tue, 2 Jun, 10:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3756

  4. Manuel Selbach uploaded patch set 3 06/03/20, 21:54

  5. TYPO3com voted on patch set 3 V -1 06/03/20, 22:08 Completed build in 13m 26s on Wed, 3 Jun, 10:08 PM Test Summary: 252 of 73359 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3808

  6. Benni Mack commented on patch set 3 06/04/20, 09:57

    Looks good to me. How about adding some basic unit tests for the CompositeExpression class?
  7. Oliver Hader commented on patch set 3 06/04/20, 10:42

  8. Benni Mack commented on patch set 3 10/13/20, 20:38

    This change is ready for review.
  9. Benni Mack rebased onto patch set 4 10/13/20, 20:38

  10. Benni Mack commented on patch set 4 10/13/20, 20:39

  11. TYPO3com voted on patch set 4 V -1 10/13/20, 20:56 Completed build in 17m 51s on Tue, 13 Oct, 08:56 PM Test Summary: 252 of 74237 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6507

  12. Anja Leichsenring rebased onto patch set 5 11/20/20, 14:22

  13. Anja Leichsenring uploaded patch set 6 11/20/20, 14:29

  14. TYPO3com voted on patch set 6 V -1 11/20/20, 14:30 Completed build in 24s on Fri, 20 Nov, 02:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7467

  15. Anja Leichsenring commented on patch set 6 11/20/20, 14:30

    I readded the test class, but it's failing ... can you please take over again?
  16. Anja Leichsenring uploaded patch set 7 11/20/20, 14:31

  17. TYPO3com voted on patch set 5 V -1 11/20/20, 14:35 Completed build in 12m 06s on Fri, 20 Nov, 02:35 PM Test Summary: 84 of 32642 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7466

  18. TYPO3com voted on patch set 7 V -1 11/20/20, 14:43 Completed build in 11m 39s on Fri, 20 Nov, 02:43 PM Test Summary: 106 of 32666 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7468

  19. Benni Mack uploaded patch set 8 05/01/21, 12:23

  20. core-ci voted on patch set 8 V -1 05/01/21, 12:38 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11009

  21. Benni Mack uploaded patch set 9 05/01/21, 13:12

  22. core-ci voted on patch set 9 V -1 05/01/21, 13:26 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11010

  23. Benni Mack rebased onto patch set 10 06/29/21, 12:37

  24. core-ci voted on patch set 10 V -1 06/29/21, 12:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12799

  25. Benni Mack abandoned the change 11/10/21, 21:19

    will not work on this in the near future. if somebody wants to pick this up, please let me know, I will restore the change