64660[!!!][TASK] Remove CSS/JS inclusion via PHP in TSFE
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Breaking-91563-PHP-basedJSCSSInclusionsForFrontendRemoved.rstnew+40 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+2 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+6 −96
- typo3/sysext/frontend/Classes/Http/RequestHandler.php3+1 −15
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php+20 −0
Review log 1218
-
Benni Mack uploaded patch set 1 06/03/20, 10:21
-
TYPO3com voted on patch set 1 V -1 06/03/20, 10:34 Completed build in 12m 42s on Wed, 3 Jun, 10:34 AM Test Summary: 7 of 73323 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3772
-
TYPO3com commented on patch set 1 06/03/20, 10:42 Completed build in 32m 56s on Wed, 3 Jun, 10:42 AM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3772
-
Benni Mack uploaded patch set 2 06/03/20, 14:47
-
TYPO3com voted on patch set 2 V -1 06/03/20, 14:58 Completed build in 11m 34s on Wed, 3 Jun, 02:58 PM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3779
-
Benni Mack uploaded patch set 3 06/03/20, 18:51
-
TYPO3com voted on patch set 3 V -1 06/03/20, 19:02 Completed build in 11m 49s on Wed, 3 Jun, 07:02 PM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3793
-
Andreas Kienast uploaded patch set 4 06/03/20, 21:00
-
Andreas Kienast voted on patch set 4 V +1 CR +1 06/03/20, 21:10
-
TYPO3com voted on patch set 4 V +1 06/03/20, 21:39 Completed build in 34m 31s on Wed, 3 Jun, 09:39 PM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3807
-
Stephan Großberndt commented on patch set 5 06/04/20, 11:05
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V +1 06/04/20, 11:17 Completed build in 12m 05s on Thu, 4 Jun, 11:17 AM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3813
-
Markus Klein commented on patch set 5 06/04/20, 12:12
RequestHandler.php:740should we preserve adding the LF before and after? -
Benni Mack commented on patch set 5 06/04/20, 12:34
RequestHandler.php:740Replyno -
Markus Klein commented on patch set 5 CR +1 06/04/20, 12:57
RequestHandler.php:740ReplyAck -
Andreas Kienast voted on patch set 5 V +1 CR +1 06/05/20, 14:35
-
Benni Mack voted on patch set 5 V +2 CR +2 06/05/20, 16:03
-
Benni Mack merged patch set 6 06/05/20, 16:03