Review main Merged

64667[TASK] Define callable controller actions

Oliver Hader CR +2 V +2 Easy +16 −7 updated 10/02/20, 15:56

Commit message

Several custom controller implementations allow calling internal
*Action methods. In order to avoid unintended behavior and to
streamline the application flow those invocations are
defined now explicitly.

ManagementController just had one possible action method and has been
simplified in this regard.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1721

  1. Oliver Hader uploaded patch set 1 06/03/20, 17:28

  2. TYPO3com voted on patch set 1 V +1 06/03/20, 17:45 Completed build in 16m 22s on Wed, 3 Jun, 05:45 PM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3783

  3. Oliver Hader voted on patch set 1 CR -1 06/03/20, 19:11

  4. Oliver Hader voted on patch set 1 CR 0 06/03/20, 19:16

  5. Benni Mack voted on patch set 1 V +1 CR +1 06/04/20, 19:09

  6. Daniel Goerz commented on patch set 1 06/14/20, 19:33

    HelpController.php:105

    Any reason for putting this check after initializeView()?
  7. Oliver Hader commented on patch set 1 CR -1 06/20/20, 08:41

    HelpController.php:105 Reply Unresolved

    > Any reason for putting this check after initializeView()? It was placed before actually "dispatching" the actions. But it could be at the beginning of the method as well. Good point!
  8. Daniel Goerz uploaded patch set 2 06/30/20, 18:39

  9. Daniel Goerz voted on patch set 2 V +1 CR +1 06/30/20, 18:40

  10. TYPO3com voted on patch set 2 V +1 06/30/20, 18:55 Completed build in 15m 12s on Tue, 30 Jun, 06:55 PM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4027

  11. Markus Klein updated the commit message in patch set 3 06/30/20, 21:14

  12. TYPO3com voted on patch set 3 V +1 06/30/20, 21:39 Completed build in 24m 15s on Tue, 30 Jun, 09:39 PM Test Summary: 72869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4028

  13. Daniel Goerz voted on patch set 3 V +1 CR +1 07/01/20, 07:32

  14. Daniel Goerz uploaded patch set 4 09/27/20, 13:26

  15. Daniel Goerz voted on patch set 4 V +1 CR +1 09/27/20, 13:26

  16. TYPO3com voted on patch set 4 V +1 09/27/20, 13:43 Completed build in 14m 46s on Sun, 27 Sep, 01:43 PM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6020

  17. Tymoteusz Motylewski commented on patch set 4 09/27/20, 21:59

    Why do we need this change? If some method should not ba callable then it should not have Action suffix. I dont see much benefit in this change.
  18. Georg Ringer voted on patch set 4 V +1 CR +1 09/28/20, 07:33

  19. Oliver Klee voted on patch set 4 CR +1 10/02/20, 11:06

  20. Christian Kuhn voted on patch set 4 V +2 CR +2 10/02/20, 15:55

  21. Christian Kuhn merged patch set 5 10/02/20, 15:56