Review main Merged

64668[TASK] Use hash_equals when comparing cryptographic hash values

Oliver Hader CR +2 V +2 Easy +6 −6 updated 06/08/20, 17:45

Commit message

Direct hash comparison is replaced by cryptographic-safe `hash_equals`.
Changes in this patch set basically don't have much impact regarding
security aspects. This is a preparation for starting with RIPS scanner.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 45

  1. Oliver Hader uploaded patch set 1 06/03/20, 17:29

  2. TYPO3com voted on patch set 1 V +1 06/03/20, 17:54 Completed build in 19m 06s on Wed, 3 Jun, 05:54 PM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3784

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/04/20, 19:15

  4. Oliver Hader voted on patch set 1 V +2 CR +2 06/08/20, 17:45

  5. Oliver Hader merged patch set 2 06/08/20, 17:45