Review main Merged Breaking

64671[!!!][TASK] Remove controller alias support

Alexander Schnitzler CR +2 V +2 Hard +90 −209 updated 10/21/20, 07:29

Commit message

Using controller aliases, i.e. the controller name only, for
plugin registration has been deprecated and is now removed.

\TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin()
and similar methods do expect fully qualified class names
instead. Controller aliases are derived from the class name.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1218

  1. Alexander Schnitzler uploaded patch set 1 06/03/20, 18:03

  2. Alexander Schnitzler wrote 06/03/20, 18:06

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V -1 06/03/20, 18:18 Completed build in 15m 02s on Wed, 3 Jun, 06:18 PM Test Summary: 1 of 73308 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3789

  4. Alexander Schnitzler rebased onto patch set 2 10/20/20, 13:31

  5. TYPO3com voted on patch set 2 V -1 10/20/20, 13:44 Completed build in 12m 53s on Tue, 20 Oct, 01:44 PM Test Summary: 1 of 73949 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6694

  6. Alexander Schnitzler uploaded patch set 3 10/20/20, 14:01

  7. Alexander Schnitzler commented on patch set 3 CR -1 10/20/20, 14:01

    Waiting for the merge of this PR: https://github.com/TYPO3/styleguide/pull/167
  8. TYPO3com voted on patch set 3 V -1 10/20/20, 14:12 Completed build in 11m 33s on Tue, 20 Oct, 02:12 PM Test Summary: 1 of 73949 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6696

  9. Benni Mack commented on patch set 3 10/20/20, 17:29

    EXT:styleguide PR is merged, now a new release for this extension is needed
  10. Christian Kuhn uploaded patch set 4 10/20/20, 21:16

  11. TYPO3com voted on patch set 4 V -1 10/20/20, 21:29 Completed build in 13m 09s on Tue, 20 Oct, 09:29 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6706

  12. Christian Kuhn uploaded patch set 5 10/20/20, 22:15

  13. TYPO3com voted on patch set 5 V -1 10/20/20, 22:28 Completed build in 13m 23s on Tue, 20 Oct, 10:28 PM Test Summary: 73487 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6709

  14. TYPO3com voted on patch set 5 V +1 10/20/20, 23:11 Completed build in 1h 08m 57s on Tue, 20 Oct, 11:11 PM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6709

  15. Christian Kuhn voted on patch set 5 V +1 CR +1 10/20/20, 23:15

  16. Georg Ringer voted on patch set 5 CR +1 10/21/20, 05:24

  17. Daniel Goerz voted on patch set 5 V +2 CR +2 10/21/20, 07:29

  18. Daniel Goerz merged patch set 6 10/21/20, 07:29