Review main Merged

64672[BUGFIX] Ensure PageContentErrorHandler content is served correctly

Markus Klein CR +2 V +2 Easy +8 −4 updated 06/07/20, 10:20

Commit message

Use only the body and the content-type header of the internal
sub-request. Everything else of the sub-request can be discarded.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Johannes Kasberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Johannes Kasberger +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1420

  1. Markus Klein uploaded patch set 1 06/03/20, 18:23

  2. Markus Klein updated the commit message in patch set 2 06/03/20, 18:33

  3. TYPO3com voted on patch set 1 V +1 06/03/20, 18:34 Completed build in 10m 59s on Wed, 3 Jun, 06:34 PM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3791

  4. TYPO3com voted on patch set 2 V +1 06/03/20, 18:45 Completed build in 11m 27s on Wed, 3 Jun, 06:45 PM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3792

  5. Johannes Kasberger voted on patch set 2 V +1 CR +1 06/03/20, 18:57

  6. Benni Mack commented on patch set 2 06/04/20, 09:56

    Would be good to have a) an issue number :D b) have a one-liner comment in the code why this is added (I know we have Git history but this helps when people start turning this code upside-down again)
  7. Markus Klein abandoned the change 06/04/20, 12:43

  8. Markus Klein restored the change 06/04/20, 12:43

  9. Markus Klein uploaded patch set 3 06/04/20, 12:46

  10. Markus Klein updated the commit message in patch set 4 06/04/20, 12:49

  11. TYPO3com voted on patch set 3 V +1 06/04/20, 12:59 Completed build in 13m 04s on Thu, 4 Jun, 12:59 PM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3816

  12. TYPO3com voted on patch set 4 V +1 06/04/20, 13:04 Completed build in 14m 48s on Thu, 4 Jun, 01:04 PM Test Summary: 72835 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3817

  13. Markus Klein uploaded patch set 5 06/04/20, 14:06

  14. TYPO3com voted on patch set 5 V -1 06/04/20, 14:06 Completed build in 27s on Thu, 4 Jun, 02:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3822

  15. Markus Klein uploaded patch set 6 06/04/20, 14:16

  16. TYPO3com voted on patch set 6 V +1 06/04/20, 14:28 Completed build in 12m 08s on Thu, 4 Jun, 02:28 PM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3824

  17. Benni Mack voted on patch set 6 CR +1 06/04/20, 19:06

  18. Johannes Kasberger voted on patch set 6 V +1 CR +1 06/04/20, 19:47

  19. Benni Mack voted on patch set 6 V +2 CR +2 06/07/20, 10:20

  20. Benni Mack merged patch set 7 06/07/20, 10:20