Review main Merged

64675[TASK] Reduce inline JavaScript for refreshing backend components

Benjamin Franzke CR +2 V +2 Hard +227 −31 updated 08/13/20, 19:41

Commit message

Left-hand module menu and top toolbar are refreshed using inline
JavaScript when e.g. an extension is de-/activated in extension
manager or users switch their backend language in setup module.

A new module `ImmediateActionElement` is introduced that
implements the Custom HTML Element `<typo3-immediate-action action="…">`.
The element immediately dispatches the action passed via the
action attribute once attached to the DOM.

We therefore drop the (currently unused) data-dispatch-immediately
attribute which was introduced in #91015, as we opt for a more
streamlined custom HTML element implementation now.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1725

  1. Benjamin Franzke uploaded patch set 1 06/03/20, 19:33

  2. TYPO3com voted on patch set 1 V -1 06/03/20, 19:35 Completed build in 21s on Wed, 3 Jun, 07:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3797

  3. Benjamin Franzke uploaded patch set 2 06/03/20, 19:40

    Rebase
  4. Oliver Hader commented on patch set 2 06/03/20, 19:46

    Nice in general! ;) But... some remarks we could think about... (I'm a fan of custom-elements and web-components, count me in!) → back-reference: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64315

    ImmediateAction.ts:24

    when introducing custom elements I'd like to see something like `ImmediateActionElement` as the name - and putting elements to new directory/namespace

    ImmediateAction.ts:27

    probably might not be the time in life-cycle of a custom element when it's actually attached to the view (it would work for the current scenario - but I'm not sure what happens if this element is part of a shadow-row or DocumentFragement template)
  5. Oliver Hader commented on patch set 2 06/03/20, 19:48

    ImmediateAction.ts:27 Reply

    *shadow-root
  6. TYPO3com voted on patch set 2 V +1 06/03/20, 19:51 Completed build in 11m 27s on Wed, 3 Jun, 07:51 PM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3798

  7. Oliver Hader commented on patch set 2 06/03/20, 19:58

    ImmediateAction.ts:27 Reply

  8. Benjamin Franzke uploaded patch set 3 2 comments 06/03/20, 20:32

  9. Benjamin Franzke uploaded patch set 4 06/03/20, 20:36

  10. TYPO3com voted on patch set 3 V +1 06/03/20, 20:45 Completed build in 12m 39s on Wed, 3 Jun, 08:45 PM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3801

  11. TYPO3com voted on patch set 4 V -1 06/03/20, 20:57 Completed build in 15m 44s on Wed, 3 Jun, 08:57 PM Test Summary: 1 of 73323 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3803

  12. Benjamin Franzke uploaded patch set 5 06/04/20, 05:12

  13. TYPO3com voted on patch set 5 V +1 06/04/20, 05:25 Completed build in 12m 29s on Thu, 4 Jun, 05:25 AM Test Summary: 72839 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3809

  14. Benjamin Franzke wrote 06/04/20, 07:56

    Topic set to inline-javascript
  15. Benjamin Franzke uploaded patch set 6 06/04/20, 08:19

  16. TYPO3com voted on patch set 6 V +1 06/04/20, 08:32 Completed build in 12m 45s on Thu, 4 Jun, 08:32 AM Test Summary: 72840 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3810

  17. Benjamin Franzke uploaded patch set 7 06/04/20, 18:28

  18. TYPO3com voted on patch set 7 V +1 06/04/20, 18:47 Completed build in 19m 05s on Thu, 4 Jun, 06:47 PM Test Summary: 72834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3833

  19. Oliver Hader voted on patch set 7 CR -1 07/13/20, 10:38

  20. Oliver Hader uploaded patch set 8 07/13/20, 11:01

  21. TYPO3com voted on patch set 8 V +1 07/13/20, 11:16 Completed build in 15m 33s on Mon, 13 Jul, 11:16 AM Test Summary: 72865 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4078

  22. Oliver Hader voted on patch set 8 V +1 CR +1 07/13/20, 11:18

  23. Oliver Hader commented on patch set 8 V +2 CR +2 07/15/20, 22:02

    @Jonas: Post reviews & additional tests are appreciated of course at any time
  24. Oliver Hader merged patch set 9 07/15/20, 22:02

  25. Markus Klein commented on patch set 9 08/13/20, 19:41

    ImmediateActionElement.ts:69 Unresolved

    This is not supported by Edge (non-chromium) See https://forge.typo3.org/issues/92001