Review main Merged

64735[TASK] Simplify rendering of ModuleTemplate with PageRenderer

Benni Mack CR +2 V +2 Easy +2 −6 updated 06/05/20, 12:57

Commit message

PageRenderer does not need to care about the actual content.
Instead of re-running everything in PageRenderer, ModuleTemplate
only calls PageRenderer->render() once.

This simplifies the PageRenderer logic and adds a bit of performance
improvements.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Benni Mack +2
    • Markus Klein +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Benni Mack uploaded patch set 1 06/04/20, 13:27

  2. TYPO3com voted on patch set 1 V +1 06/04/20, 13:39 Completed build in 11m 48s on Thu, 4 Jun, 01:39 PM Test Summary: 72836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3821

  3. Wouter Wolters voted on patch set 1 CR +1 06/05/20, 10:19

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 06/05/20, 10:32

  5. Markus Klein voted on patch set 1 V +1 CR +1 06/05/20, 12:46

  6. Frank Nägler voted on patch set 1 V +2 CR +2 06/05/20, 12:57

  7. Benni Mack voted on patch set 1 V +2 CR +2 06/05/20, 12:57

  8. Benni Mack merged patch set 2 06/05/20, 12:57