Review main Abandoned

64773[BUGFIX] Loosen deprecation for caching framework changes

Benni Mack CR 0 V 0 Easy +29 −16 updated 07/08/20, 17:47

Commit message

TYPO3 v10.0 introduced the renaming of core caching framework caches
by removing the "cache_" prefix from their identifiers.

This change loosens the deprecation by not triggering a deprecation
log and only focus on the core caches, and not third party caches for migrations.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 911

  1. Benni Mack uploaded patch set 1 06/04/20, 19:08

  2. TYPO3com voted on patch set 1 V -1 06/04/20, 19:20 Completed build in 11m 53s on Thu, 4 Jun, 07:20 PM Test Summary: 6 of 73317 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3835

  3. Andreas Kienast uploaded patch set 2 06/04/20, 19:29

  4. Claus Due voted on patch set 2 CR +1 06/04/20, 19:35

  5. TYPO3com voted on patch set 2 V +1 06/04/20, 20:17 Completed build in 33m 52s on Thu, 4 Jun, 08:17 PM Test Summary: 72830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3840

  6. Oliver Klee commented on patch set 2 CR +1 06/05/20, 09:10

    CacheManager.php:50 Unresolved

    <3
  7. Andreas Kienast voted on patch set 2 V +1 CR +1 06/05/20, 09:13

  8. Frank Nägler commented on patch set 2 06/05/20, 10:09

    I am not happy with this solution. 1. We will have a breaking change in v12 without deprecations logs before 2. Deprecations are made to adjust extensions/usages in third party code, so "fix it in your code" is the valid solution If we really really really need a different solution as the usaual deprecation way, what about merging this patch only into v10 and keep the deprecation messages for v11 so we can safly remove the code in v12?
  9. Claus Due commented on patch set 2 06/05/20, 10:44

    Alternative suggestion: * Do not schedule this alias translation for removal, plan to keep indefinitely * Do not dispatch any deprecation notices since the translation is kept indefinitely Benefit: * Configuration that works on earlier LTS versions works on new LTS versions * You can still document the preferred naming but it doesn't constitute an error that person X might be using the old names Keep in mind there are very valid reasons (multi-LTS-support without conditional configuration, forexample) to not aggressively deprecate such things as configuration. Also keep in mind that what we're talking about potentially keeping indefinitely is one condition and one translation array - there is nearly zero impact, so why would we make life harder for developers of multi-version supporting projects if we really don't have to? Why would we hard-deprecate just for the sake of avoiding one condition?
  10. Claus Due commented on patch set 2 06/05/20, 10:47

    > * Configuration that works on earlier LTS versions works on new LTS versions Not just configuration but also implementation, e.g. an extension which integrates with core caches and needs to work with earlier and more recent LTS versions would need a condition in every place that uses getCache() to retrieve a core cache frontend. If we leave this silent translation in place then that becomes a complete non-issue. Cross-version compatibility is then possible without adding complexity to the implementer.
  11. Benni Mack abandoned the change 07/08/20, 17:47

    looks like nothing is happening here... no interest? Will abandon this change for the time being. We can restore this change later if there is interest in it.