Review 10.4 Merged

64774[TASK] Define callable controller actions

Oliver Hader CR +2 V +2 Easy +16 −7 updated 10/02/20, 18:32

Commit message

Several custom controller implementations allow calling internal
*Action methods. In order to avoid unintended behavior and to
streamline the application flow those invocations are
defined now explicitly.

ManagementController just had one possible action method and has been
simplified in this regard.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 816

  1. Oliver Hader uploaded patch set 1 06/04/20, 19:17

  2. TYPO3com voted on patch set 1 V +1 06/04/20, 19:41 Completed build in 21m 17s on Thu, 4 Jun, 07:41 PM Test Summary: 73817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-26

  3. Oliver Hader voted on patch set 1 CR -1 06/20/20, 08:41

  4. Markus Klein updated the commit message in patch set 2 06/30/20, 21:15

  5. TYPO3com voted on patch set 2 V -1 06/30/20, 21:44 Completed build in 28m 54s on Tue, 30 Jun, 09:44 PM Test Summary: 3 of 74368 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-68

  6. Oliver Hader uploaded patch set 3 07/03/20, 14:50

  7. TYPO3com voted on patch set 3 V -1 07/03/20, 15:19 Completed build in 28m 46s on Fri, 3 Jul, 03:18 PM Test Summary: 72561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-69

  8. TYPO3com commented on patch set 3 07/03/20, 15:50 Completed build in 1h 29m 29s on Fri, 3 Jul, 03:50 PM Test Summary: 73882 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-69

  9. TYPO3com voted on patch set 2 V +1 07/03/20, 17:09 Completed build in 20h 23m 18s on Fri, 3 Jul, 05:09 PM Test Summary: 73883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-68

  10. TYPO3com voted on patch set 3 V +1 07/06/20, 16:41 Completed build in 5h 14m 17s on Mon, 6 Jul, 04:41 PM Test Summary: 73883 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-69

  11. Georg Ringer voted on patch set 3 V +1 CR +1 07/07/20, 09:17

  12. Christian Kuhn uploaded patch set 4 10/02/20, 16:06

  13. TYPO3com voted on patch set 4 V -1 10/02/20, 17:04 Completed build in 54m 33s on Fri, 2 Oct, 05:04 PM Test Summary: 1 of 75243 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-562

  14. TYPO3com voted on patch set 4 V +1 10/02/20, 17:20 Completed build in 2h 05m 38s on Fri, 2 Oct, 05:20 PM Test Summary: 74758 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-562

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 10/02/20, 18:32

  16. Christian Kuhn merged patch set 5 10/02/20, 18:32