Review 9.5 Merged

64776[TASK] Define callable controller actions

Oliver Hader CR +2 V +2 Easy +16 −6 updated 10/02/20, 16:01

Commit message

Several custom controller implementations allow calling internal
*Action methods. In order to avoid unintended behavior and to
streamline the application flow those invocations are
defined now explicitly.

ManagementController just had one possible action method and has been
simplified in this regard.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 610

  1. Oliver Hader uploaded patch set 1 06/04/20, 19:19

  2. TYPO3com voted on patch set 1 V +1 06/04/20, 19:33 Completed build in 13m 22s on Thu, 4 Jun, 07:33 PM Test Summary: 74968 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-680

  3. Oliver Hader voted on patch set 1 CR -1 06/20/20, 08:41

  4. Markus Klein updated the commit message in patch set 2 06/30/20, 21:15

  5. TYPO3com voted on patch set 2 V +1 06/30/20, 21:50 Completed build in 25m 56s on Tue, 30 Jun, 09:50 PM Test Summary: 75037 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-696

  6. Oliver Hader uploaded patch set 3 07/03/20, 14:53

  7. TYPO3com voted on patch set 3 V -1 07/03/20, 15:40 Completed build in 29m 59s on Fri, 3 Jul, 03:40 PM Test Summary: 3 of 71252 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-697

  8. TYPO3com voted on patch set 3 V +1 07/03/20, 17:20 Completed build in 2h 40m 06s on Fri, 3 Jul, 05:20 PM Test Summary: 75037 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-697

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 10/02/20, 16:01

  10. Christian Kuhn merged patch set 4 10/02/20, 16:01