Review 9.5 Merged

64777[TASK] Use hash_equals when comparing cryptographic hash values

Oliver Hader CR +2 V +2 Easy +6 −6 updated 06/08/20, 17:46

Commit message

Direct hash comparison is replaced by cryptographic-safe `hash_equals`.
Changes in this patch set basically don't have much impact regarding
security aspects. This is a preparation for starting with RIPS scanner.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Tomas Norre Mikkelsen +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 56

  1. Oliver Hader uploaded patch set 1 06/04/20, 19:19

  2. TYPO3com voted on patch set 1 V +1 06/04/20, 19:53 Completed build in 32m 42s on Thu, 4 Jun, 07:53 PM Test Summary: 74968 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-681

  3. Oliver Klee voted on patch set 1 CR +1 06/04/20, 21:46

  4. Tomas Norre Mikkelsen voted on patch set 1 CR +1 06/05/20, 08:17

  5. Oliver Hader voted on patch set 1 V +2 CR +2 06/08/20, 17:46

  6. Oliver Hader merged patch set 2 06/08/20, 17:46