Review main Merged

64778[TASK] Harden internal state handling

Oliver Hader CR +2 V +2 Easy +5 −5 updated 06/05/20, 10:36

Commit message

Internal components using `unserialize` are enforced to disallow
classes in their internal state representation. This is a preparation
for starting with RIPS scanner.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 78

  1. Oliver Hader uploaded patch set 1 06/04/20, 19:25

  2. TYPO3com voted on patch set 1 V +1 06/04/20, 20:06 Completed build in 22m 36s on Thu, 4 Jun, 08:06 PM Test Summary: 72830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3837

  3. Mathias Brodala commented on patch set 1 CR -1 06/05/20, 06:36

    TypoScriptParser.php:480

    There is no 3rd argument to unserialize(). Also this changes the logic here completely. Until now 1 was passed (which should have been "true" instead) to allow all classes.
  4. Oliver Hader commented on patch set 1 06/05/20, 06:59

    TypoScriptParser.php:480 Reply

    Please read again carefully, `1` is the 3rd argument to `setVal`
  5. Mathias Brodala commented on patch set 1 CR 0 06/05/20, 07:02

    TypoScriptParser.php:480 Reply

    Oh, you are right, sorry.
  6. Andreas Kienast voted on patch set 1 V +1 CR +1 06/05/20, 08:34

  7. Frank Nägler voted on patch set 1 V +2 CR +2 06/05/20, 10:36

  8. Frank Nägler merged patch set 2 06/05/20, 10:36