Review main Merged

64783[BUGFIX] Use hashed object identifier in IRRE for nprogress

Andreas Kienast CR +2 V +2 Easy +13 −7 updated 06/29/20, 17:37

Commit message

nprogress is used to indicate activity when a collapsed IRRE node is
about to get loaded. In case of FlexForms the id attribute may contain a
dot which is not an issue if handled correctly.
However, nprogress doesn't treat this value as an id, but rather as a
full CSS selector which causes issues and breaks loading the IRRE node.

To work around this issue, the id of the container used to render the
progress bar is now MD5 hashed.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1924

  1. Andreas Kienast uploaded patch set 1 06/04/20, 20:30

  2. Andreas Kienast uploaded patch set 2 06/04/20, 20:32

  3. TYPO3com voted on patch set 2 V -1 06/04/20, 20:54 Completed build in 17m 51s on Thu, 4 Jun, 08:54 PM Test Summary: 6 of 73317 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3844

  4. Jonas Temmen commented on patch set 2 V +1 06/04/20, 21:13

    works for me
  5. Andreas Kienast uploaded patch set 3 06/04/20, 21:26

  6. Andreas Kienast uploaded patch set 4 06/04/20, 21:26

  7. Andreas Kienast uploaded patch set 5 06/04/20, 21:27

  8. TYPO3com voted on patch set 3 V +1 06/04/20, 21:44 Completed build in 18m 08s on Thu, 4 Jun, 09:44 PM Test Summary: 72830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3847

  9. TYPO3com voted on patch set 5 V +1 06/04/20, 21:52 Completed build in 18m 05s on Thu, 4 Jun, 09:52 PM Test Summary: 72830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3849

  10. Andreas Kienast wrote 06/27/20, 09:39

    Topic set to javascript
  11. Andreas Kienast uploaded patch set 6 06/27/20, 09:40

  12. TYPO3com voted on patch set 6 V +1 06/27/20, 09:52 Completed build in 11m 43s on Sat, 27 Jun, 09:52 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3992

  13. Anja Leichsenring updated the commit message in patch set 7 06/27/20, 10:07

  14. TYPO3com voted on patch set 7 V +1 06/27/20, 10:20 Completed build in 12m 39s on Sat, 27 Jun, 10:20 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3993

  15. Anja Leichsenring commented on patch set 7 V +1 CR +1 06/27/20, 10:23

    tested with styleguide page flex record 1 tab inline (and this needs an update in ext:styleguide).
  16. Anja Leichsenring commented on patch set 7 06/27/20, 11:04

    > Patch Set 7: Verified+1 Code-Review+1 > > tested with styleguide page flex record 1 tab inline (and this needs an update in ext:styleguide). here is the commit to ext:styleguide, should ease the testing: https://github.com/TYPO3/styleguide/commit/6dbb1e702442b98e055e57e9d2c64c0221a4fcdc
  17. Oliver Hader voted on patch set 7 CR +1 06/28/20, 07:35

  18. Daniel Goerz commented on patch set 7 06/29/20, 08:08

    > Patch Set 7: > > > Patch Set 7: Verified+1 Code-Review+1 > > > > tested with styleguide page flex record 1 tab inline (and this needs an update in ext:styleguide). > > here is the commit to ext:styleguide, should ease the testing: https://github.com/TYPO3/styleguide/commit/6dbb1e702442b98e055e57e9d2c64c0221a4fcdc I am unable to reproduce an error with styleguide "flex" (tab "inline"). With the default value for sys_language_uid set, I can add inline elements and save them to db without an issue? How did you reproduce exactly?
  19. Anja Leichsenring commented on patch set 7 06/29/20, 16:58

    > Patch Set 7: > > > Patch Set 7: > > > > > Patch Set 7: Verified+1 Code-Review+1 > > > > > > tested with styleguide page flex record 1 tab inline (and this needs an update in ext:styleguide). > > > > here is the commit to ext:styleguide, should ease the testing: https://github.com/TYPO3/styleguide/commit/6dbb1e702442b98e055e57e9d2c64c0221a4fcdc > > I am unable to reproduce an error with styleguide "flex" (tab "inline"). With the default value for sys_language_uid set, I can add inline elements and save them to db without an issue? How did you reproduce exactly? when just using master with the shipped ext:styleguide, adding a new inline record to the mentinoned field will provide the error the issue author described. Adding the patch will make the same thing fail with a mysql error (my master runs on mysql) due to sys_language_uid value not being an integer. When you then apply the patch to ext:styleguide, that I mentioned, you will be able to add as many inline records to the flex record as you wish for.
  20. Daniel Goerz commented on patch set 7 06/29/20, 17:13

    > Patch Set 7: > > > Patch Set 7: > > > > > Patch Set 7: > > > > > > > Patch Set 7: Verified+1 Code-Review+1 > > > > > > > > tested with styleguide page flex record 1 tab inline (and this needs an update in ext:styleguide). > > > > > > here is the commit to ext:styleguide, should ease the testing: https://github.com/TYPO3/styleguide/commit/6dbb1e702442b98e055e57e9d2c64c0221a4fcdc > > > > I am unable to reproduce an error with styleguide "flex" (tab "inline"). With the default value for sys_language_uid set, I can add inline elements and save them to db without an issue? How did you reproduce exactly? > > when just using master with the shipped ext:styleguide, adding a new inline record to the mentinoned field will provide the error the issue author described. Adding the patch will make the same thing fail with a mysql error (my master runs on mysql) due to sys_language_uid value not being an integer. > When you then apply the patch to ext:styleguide, that I mentioned, you will be able to add as many inline records to the flex record as you wish for. Works for me without the patch in FF and Chrome.
  21. Daniel Goerz commented on patch set 7 06/29/20, 17:16

    The ID of what field contains a dot?
  22. Andreas Kienast commented on patch set 7 06/29/20, 17:24

    > Patch Set 7: > > The ID of what field contains a dot? IIRC, I‘ve added a field `settings.foobar` on Flexform utilizing FAL, using the config from the original ticket of the previous bugfix.
  23. Daniel Goerz commented on patch set 7 V +2 CR +2 06/29/20, 17:37

    > Patch Set 7: > > > Patch Set 7: > > > > The ID of what field contains a dot? > > IIRC, I‘ve added a field `settings.foobar` on Flexform utilizing FAL, using the config from the original ticket of the previous bugfix. Ah - now we're talking. Renaming the styleguide flexform field from inline to something with a dot broke it. Patch fixes it. Me happy now.
  24. Daniel Goerz merged patch set 8 06/29/20, 17:37