64783[BUGFIX] Use hashed object identifier in IRRE for nprogress
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Anja Leichsenring +1
- Oliver Hader +1
-
Verified V +2 Done
- Daniel Goerz +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1924
-
Andreas Kienast uploaded patch set 1 06/04/20, 20:30
-
Andreas Kienast uploaded patch set 2 06/04/20, 20:32
-
TYPO3com voted on patch set 2 V -1 06/04/20, 20:54 Completed build in 17m 51s on Thu, 4 Jun, 08:54 PM Test Summary: 6 of 73317 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3844
-
Jonas Temmen commented on patch set 2 V +1 06/04/20, 21:13
works for me -
Andreas Kienast uploaded patch set 3 06/04/20, 21:26
-
Andreas Kienast uploaded patch set 4 06/04/20, 21:26
-
Andreas Kienast uploaded patch set 5 06/04/20, 21:27
-
TYPO3com voted on patch set 3 V +1 06/04/20, 21:44 Completed build in 18m 08s on Thu, 4 Jun, 09:44 PM Test Summary: 72830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3847
-
TYPO3com voted on patch set 5 V +1 06/04/20, 21:52 Completed build in 18m 05s on Thu, 4 Jun, 09:52 PM Test Summary: 72830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3849
-
Andreas Kienast wrote 06/27/20, 09:39
Topic set to javascript -
Andreas Kienast uploaded patch set 6 06/27/20, 09:40
-
TYPO3com voted on patch set 6 V +1 06/27/20, 09:52 Completed build in 11m 43s on Sat, 27 Jun, 09:52 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3992
-
Anja Leichsenring updated the commit message in patch set 7 06/27/20, 10:07
-
TYPO3com voted on patch set 7 V +1 06/27/20, 10:20 Completed build in 12m 39s on Sat, 27 Jun, 10:20 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3993
-
Anja Leichsenring commented on patch set 7 V +1 CR +1 06/27/20, 10:23
tested with styleguide page flex record 1 tab inline (and this needs an update in ext:styleguide). -
Anja Leichsenring commented on patch set 7 06/27/20, 11:04
> Patch Set 7: Verified+1 Code-Review+1 > > tested with styleguide page flex record 1 tab inline (and this needs an update in ext:styleguide). here is the commit to ext:styleguide, should ease the testing: https://github.com/TYPO3/styleguide/commit/6dbb1e702442b98e055e57e9d2c64c0221a4fcdc -
Oliver Hader voted on patch set 7 CR +1 06/28/20, 07:35
-
Daniel Goerz commented on patch set 7 06/29/20, 08:08
> Patch Set 7: > > > Patch Set 7: Verified+1 Code-Review+1 > > > > tested with styleguide page flex record 1 tab inline (and this needs an update in ext:styleguide). > > here is the commit to ext:styleguide, should ease the testing: https://github.com/TYPO3/styleguide/commit/6dbb1e702442b98e055e57e9d2c64c0221a4fcdc I am unable to reproduce an error with styleguide "flex" (tab "inline"). With the default value for sys_language_uid set, I can add inline elements and save them to db without an issue? How did you reproduce exactly? -
Anja Leichsenring commented on patch set 7 06/29/20, 16:58
> Patch Set 7: > > > Patch Set 7: > > > > > Patch Set 7: Verified+1 Code-Review+1 > > > > > > tested with styleguide page flex record 1 tab inline (and this needs an update in ext:styleguide). > > > > here is the commit to ext:styleguide, should ease the testing: https://github.com/TYPO3/styleguide/commit/6dbb1e702442b98e055e57e9d2c64c0221a4fcdc > > I am unable to reproduce an error with styleguide "flex" (tab "inline"). With the default value for sys_language_uid set, I can add inline elements and save them to db without an issue? How did you reproduce exactly? when just using master with the shipped ext:styleguide, adding a new inline record to the mentinoned field will provide the error the issue author described. Adding the patch will make the same thing fail with a mysql error (my master runs on mysql) due to sys_language_uid value not being an integer. When you then apply the patch to ext:styleguide, that I mentioned, you will be able to add as many inline records to the flex record as you wish for. -
Daniel Goerz commented on patch set 7 06/29/20, 17:13
> Patch Set 7: > > > Patch Set 7: > > > > > Patch Set 7: > > > > > > > Patch Set 7: Verified+1 Code-Review+1 > > > > > > > > tested with styleguide page flex record 1 tab inline (and this needs an update in ext:styleguide). > > > > > > here is the commit to ext:styleguide, should ease the testing: https://github.com/TYPO3/styleguide/commit/6dbb1e702442b98e055e57e9d2c64c0221a4fcdc > > > > I am unable to reproduce an error with styleguide "flex" (tab "inline"). With the default value for sys_language_uid set, I can add inline elements and save them to db without an issue? How did you reproduce exactly? > > when just using master with the shipped ext:styleguide, adding a new inline record to the mentinoned field will provide the error the issue author described. Adding the patch will make the same thing fail with a mysql error (my master runs on mysql) due to sys_language_uid value not being an integer. > When you then apply the patch to ext:styleguide, that I mentioned, you will be able to add as many inline records to the flex record as you wish for. Works for me without the patch in FF and Chrome. -
Daniel Goerz commented on patch set 7 06/29/20, 17:16
The ID of what field contains a dot? -
Andreas Kienast commented on patch set 7 06/29/20, 17:24
> Patch Set 7: > > The ID of what field contains a dot? IIRC, I‘ve added a field `settings.foobar` on Flexform utilizing FAL, using the config from the original ticket of the previous bugfix. -
Daniel Goerz commented on patch set 7 V +2 CR +2 06/29/20, 17:37
> Patch Set 7: > > > Patch Set 7: > > > > The ID of what field contains a dot? > > IIRC, I‘ve added a field `settings.foobar` on Flexform utilizing FAL, using the config from the original ticket of the previous bugfix. Ah - now we're talking. Renaming the styleguide flexform field from inline to something with a dot broke it. Patch fixes it. Me happy now. -
Daniel Goerz merged patch set 8 06/29/20, 17:37