Review main Merged

64784[TASK] Store tab menu states in sessionStorage

Andreas Kienast CR +2 V +2 Easy +8 −16 updated 07/17/20, 13:22

Commit message

The tab handling now utilizes the BrowserSession module to store the tab
menu states in the browser's sessionStorage. These values get removed
after the browser's session is closed with renders the manual expiry
handling obsolete.

Additionally, all previously in localStorage stored states get removed
as they are not required anymore.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2329

Show 34 earlier messages
  1. Andreas Kienast uploaded patch set 1 06/04/20, 21:14

  2. TYPO3com voted on patch set 1 V +1 06/04/20, 21:36 Completed build in 22m 09s on Thu, 4 Jun, 09:36 PM Test Summary: 72830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3846

  3. Andreas Kienast wrote 06/27/20, 09:39

    Topic set to javascript
  4. Anja Leichsenring commented on patch set 1 V +1 CR +1 06/27/20, 10:06

    not sure how to test, so I just clicked in BE (styleguide tree) to check for tab menus. They seem to be fine.
  1. Anja Leichsenring commented on patch set 1 06/27/20, 10:54

    > Patch Set 1: Verified+1 Code-Review+1 > > not sure how to test, so I just clicked in BE (styleguide tree) to check for tab menus. They seem to be fine. here is the commit to ext:styleguide, should ease the testing: https://github.com/TYPO3/styleguide/commit/6dbb1e702442b98e055e57e9d2c64c0221a4fcdc
  2. Oliver Hader commented on patch set 1 06/28/20, 07:35

    Hm... what does that mean when I have a view open for more than 1800 seconds (timeout) and save/reload it? Besides that, I wonder if sessionStorage could be used instead of localStorage for this use-case.
  3. Andreas Kienast commented on patch set 1 06/28/20, 09:13

    > Patch Set 1: > > Hm... what does that mean when I have a view open for more than 1800 seconds (timeout) and save/reload it? With a probability of 10% the first tab will be selected again. > Besides that, I wonder if sessionStorage could be used instead of localStorage for this use-case. Possible yes, but not feasible as the tab state is stored per content element. I fear this might explode our UC field (that's what the Persistent storage module uses).
  4. Oliver Hader commented on patch set 1 06/28/20, 14:44

    > Patch Set 1: > > > Patch Set 1: > > > > Hm... what does that mean when I have a view open for more than 1800 seconds (timeout) and save/reload it? > > With a probability of 10% the first tab will be selected again. > > > Besides that, I wonder if sessionStorage could be used instead of localStorage for this use-case. > > Possible yes, but not feasible as the tab state is stored per content element. I fear this might explode our UC field (that's what the Persistent storage module uses). I had https://developer.mozilla.org/de/docs/Web/API/Window/sessionStorage in mind - basically localStorage that is purged once the browser session ends (tab/window is closed).
  5. Markus Klein commented on patch set 1 06/29/20, 07:31

    Tabs.ts:43

    what is this non-capturing group (?:.*) good for?
  6. Andreas Kienast commented on patch set 1 06/29/20, 07:44

    Tabs.ts:43 Reply

    I want the "tabs" in the same match group. Without ?:, I have two match groups, according to regex101.
  7. Andreas Kienast commented on patch set 1 06/29/20, 07:46

    > Patch Set 1: > > I had https://developer.mozilla.org/de/docs/Web/API/Window/sessionStorage in mind - basically localStorage that is purged once the browser session ends (tab/window is closed). Nice, I didn't know that.
  8. Markus Klein commented on patch set 1 06/29/20, 07:53

    Tabs.ts:43 Reply

    why then a grouping at all? (tabs.*) will do it. but I guess you actually want (tabs[^.]*) to have it non-greedy on the dot.
  9. Andreas Kienast commented on patch set 1 06/29/20, 08:04

    Tabs.ts:43 Reply Unresolved

    If this works it's fine for me
  10. Andreas Kienast commented on patch set 1 CR -2 06/30/20, 06:10

    I'll add sessionStorage soon as proposed by Olly
  11. Andreas Kienast commented on patch set 1 07/03/20, 08:04

  12. Andreas Kienast uploaded patch set 2 07/03/20, 10:50

  13. Frank Nägler voted on patch set 2 V +1 CR +1 07/03/20, 11:37

  14. TYPO3com voted on patch set 2 V -1 07/03/20, 12:08 Completed build in 1h 07m 19s on Fri, 3 Jul, 12:08 PM Test Summary: 32 of 73356 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4043

  15. TYPO3com commented on patch set 2 07/03/20, 17:10 Completed build in 7h 15m 48s on Fri, 3 Jul, 05:10 PM Test Summary: 32 of 73356 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4043

  16. Andreas Kienast rebased onto patch set 3 07/10/20, 09:55

  17. Andreas Kienast voted on patch set 3 CR 0 07/10/20, 09:57

  18. TYPO3com voted on patch set 3 V -1 07/10/20, 10:16 Completed build in 20m 34s on Fri, 10 Jul, 10:16 AM Test Summary: 72331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4059

  19. TYPO3com voted on patch set 3 V +1 07/10/20, 11:14 Completed build in 1h 38m 48s on Fri, 10 Jul, 11:14 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4059

  20. Torben Hansen updated the commit message in patch set 4 07/10/20, 17:13

  21. TYPO3com voted on patch set 4 V +1 07/10/20, 17:28 Completed build in 14m 39s on Fri, 10 Jul, 05:27 PM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4063

  22. Frank Nägler voted on patch set 4 V +1 CR +1 07/17/20, 13:17

  23. Benjamin Kott voted on patch set 4 V +1 CR +1 07/17/20, 13:22

  24. Frank Nägler voted on patch set 4 V +2 CR +2 07/17/20, 13:22

  25. Frank Nägler merged patch set 5 07/17/20, 13:22