Review main Merged

64789[TASK] Remove ObjectManager from Extensionmanager

Benni Mack CR +2 V +2 Hard +141 −262 updated 07/27/20, 14:38

Commit message

ObjectManager is not used anymore in ExtensionManager,
except for e.g. Controllers and Repository logic.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 17

Review log 2333

Show 68 earlier messages
  1. Benni Mack uploaded patch set 1 06/05/20, 13:22

  2. TYPO3com voted on patch set 1 V -1 06/05/20, 13:35 Completed build in 12m 24s on Fri, 5 Jun, 01:35 PM Test Summary: 111 of 73287 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3857

  3. Oliver Klee commented on patch set 1 06/06/20, 11:12

    ExtensionStatus.php:41

    This removal looks like it was an accident.
  4. Andreas Kienast commented on patch set 1 06/08/20, 09:08

    ExtensionStatus.php:41 Reply

    Arguably, the property is unused
  5. Benjamin Franzke commented on patch set 1 06/08/20, 09:21

    ActivateExtensionCommand.php:69

    I would like to switch directly to dependency injection in cases like these (e.g. single purpose classes where classes are not needed to be lazy loaded), no need for GU::makeInstance then. (refactoring makeInstance to dependency injection would otherwise be another change later on).
  6. Benjamin Franzke uploaded patch set 2 2 comments 06/08/20, 20:51

  7. TYPO3com voted on patch set 2 V -1 06/08/20, 21:04 Completed build in 12m 34s on Mon, 8 Jun, 09:04 PM Test Summary: 110 of 73311 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3892

  8. Benni Mack uploaded patch set 3 06/09/20, 08:39

  1. TYPO3com voted on patch set 3 V -1 06/09/20, 08:54 Completed build in 15m 10s on Tue, 9 Jun, 08:54 AM Test Summary: 3 of 73341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3894

  2. Benni Mack uploaded patch set 4 06/09/20, 11:02

  3. TYPO3com voted on patch set 4 V -1 06/09/20, 11:16 Completed build in 14m 43s on Tue, 9 Jun, 11:16 AM Test Summary: 2 of 73341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3895

  4. TYPO3com commented on patch set 4 06/09/20, 11:25 Completed build in 38m 00s on Tue, 9 Jun, 11:25 AM Test Summary: 2 of 73341 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3895

  5. Oliver Klee commented on patch set 4 06/11/20, 17:16

    ExtensionStatus.php:41 Reply Unresolved

    Then we indeed should remove it. However, I'd like to keep this as "one change per changeset", i.e., I propose moving this part to a separate changeset.
  6. Benni Mack uploaded patch set 5 07/13/20, 11:43

  7. TYPO3com voted on patch set 5 V -1 07/13/20, 12:01 Completed build in 16m 43s on Mon, 13 Jul, 12:01 PM Test Summary: 2 of 73344 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4081

  8. Benni Mack uploaded patch set 6 07/13/20, 15:48

  9. TYPO3com voted on patch set 6 V -1 07/13/20, 16:03 Completed build in 13m 58s on Mon, 13 Jul, 04:03 PM Test Summary: 6 of 73344 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4083

  10. Benni Mack uploaded patch set 7 07/13/20, 17:06

  11. TYPO3com voted on patch set 7 V +1 07/13/20, 17:17 Completed build in 11m 16s on Mon, 13 Jul, 05:17 PM Test Summary: 72857 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4084

  12. Benni Mack updated the commit message in patch set 8 07/13/20, 19:03

  13. TYPO3com voted on patch set 8 V -1 07/13/20, 19:15 Completed build in 11m 48s on Mon, 13 Jul, 07:15 PM Test Summary: 72338 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4085

  14. TYPO3com voted on patch set 8 V +1 07/13/20, 19:26 Completed build in 34m 47s on Mon, 13 Jul, 07:26 PM Test Summary: 72857 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4085

  15. Daniel Goerz voted on patch set 8 CR +1 07/14/20, 06:48

  16. Oliver Klee commented on patch set 8 07/14/20, 09:53

    ExtensionStatusTest.php:171

    Any particular reason why you are removing this test?
  17. Benni Mack commented on patch set 8 07/14/20, 12:17

    ExtensionStatusTest.php:171 Reply

    Yes. The code (after removing the mocks) would have been 1:1 the same as the next test below.
  18. Oliver Klee commented on patch set 8 07/14/20, 13:42

    ExtensionStatusTest.php:171 Reply

    Ack
  19. Daniel Goerz voted on patch set 8 V +1 07/21/20, 07:00

  20. Christian Kuhn commented on patch set 8 07/27/20, 13:30

    A couple of ObjectManager calls are left. Is that intended? lolli@apoc:/var/www/local/coremaster/public$ ack objectManager typo3/sysext/extensionmanager/ typo3/sysext/extensionmanager/Classes/Controller/AbstractModuleController.php 93: $uriBuilder = $this->objectManager->get(UriBuilder::class); 126: $uriBuilder = $this->objectManager->get(UriBuilder::class); typo3/sysext/extensionmanager/Classes/Domain/Repository/RepositoryRepository.php 32: $defaultQuerySettings = $this->objectManager->get(QuerySettingsInterface::class); typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php 46: $defaultQuerySettings = $this->objectManager->get(QuerySettingsInterface::class); typo3/sysext/extensionmanager/Tests/Unit/Utility/DependencyUtilityTest.php 38: protected $objectManagerMock; 46: $this->objectManagerMock = $this->getMockBuilder(ObjectManagerInterface::class)->getMock(); 387: ->setConstructorArgs([$this->objectManagerMock]) 404: ->setConstructorArgs([$this->objectManagerMock]) 425: ->setConstructorArgs([$this->objectManagerMock]) 444: ->setConstructorArgs([$this->objectManagerMock]) 518: ->setConstructorArgs([$this->objectManagerMock])
  21. Christian Kuhn commented on patch set 8 07/27/20, 13:36

    Actually 2 more hits in tests, search case insensitive ... eg, 'ack objectManager -i typo3/sysext/extensionmanager/'
  22. Christian Kuhn commented on patch set 8 V +1 CR -1 07/27/20, 13:54

    +1 testing but -1 on reading for the time being. will sort out some details with benni directly.
  23. Christian Kuhn voted on patch set 8 CR +1 07/27/20, 14:37

  24. Benni Mack voted on patch set 8 V +2 CR +2 07/27/20, 14:38

  25. Benni Mack merged patch set 9 07/27/20, 14:38