Review main Abandoned Breaking

64790[!!!][FEATURE] Refactor indexed search

Tizian Schmidlin CR 0 V 0 Expert +914 −237 updated 12/09/21, 00:52

Commit message

Building on the work done for TYPO3 10.4.x, this patch
redefines concerns inside the Indexer and provides
an IndexerInterface for better extendability and drop-in
solutions.

Instead of managing the external parsers in the Indexer,
the SearchController or the AdminSearchController, the
external parsers are now handled as FileContentParsers
with a proper interface to ensure extendability for new
file formats to support.

Also the WorkerInterface now relies on the
IndexerInterface to be present for all calls to `->index`
which stabilises the API.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 19

Review log 2543

Show 1018 earlier messages
  1. Tizian Schmidlin uploaded patch set 1 06/05/20, 14:24

  2. Tizian Schmidlin updated the commit message in patch set 2 06/05/20, 14:27

  3. TYPO3com voted on patch set 1 V +1 06/05/20, 14:49 Completed build in 19m 31s on Fri, 5 Jun, 02:48 PM Test Summary: 72800 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3869

  4. TYPO3com voted on patch set 2 V +1 06/05/20, 14:52 Completed build in 23m 27s on Fri, 5 Jun, 02:52 PM Test Summary: 72800 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3870

  5. Tizian Schmidlin uploaded patch set 3 06/15/20, 10:59

  6. TYPO3com voted on patch set 3 V -1 06/15/20, 10:59 Completed build in 22s on Mon, 15 Jun, 10:59 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3916

  7. Tizian Schmidlin uploaded patch set 4 07/27/20, 06:52

  8. TYPO3com voted on patch set 4 V -1 07/27/20, 06:52 Completed build in 26s on Mon, 27 Jul, 06:52 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4264

  9. Tizian Schmidlin uploaded patch set 5 07/27/20, 06:53

  10. TYPO3com voted on patch set 5 V -1 07/27/20, 06:53 Completed build in 25s on Mon, 27 Jul, 06:53 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4265

  11. Tizian Schmidlin uploaded patch set 6 07/27/20, 07:48

  12. TYPO3com voted on patch set 6 V -1 07/27/20, 07:48 Completed build in 24s on Mon, 27 Jul, 07:48 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4266

  13. Tizian Schmidlin uploaded patch set 7 07/27/20, 07:59

  14. TYPO3com voted on patch set 7 V -1 07/27/20, 08:00 Completed build in 24s on Mon, 27 Jul, 07:59 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4267

  15. Tizian Schmidlin uploaded patch set 8 07/27/20, 08:07

  16. TYPO3com voted on patch set 8 V -1 07/27/20, 08:18 Completed build in 10m 58s on Mon, 27 Jul, 08:18 AM Test Summary: 72928 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4268

  17. Tizian Schmidlin uploaded patch set 9 07/27/20, 08:26

  18. Tizian Schmidlin uploaded patch set 10 07/27/20, 08:35

  1. Tizian Schmidlin uploaded patch set 11 07/27/20, 08:36

  2. TYPO3com voted on patch set 9 V -1 07/27/20, 08:40 Completed build in 13m 35s on Mon, 27 Jul, 08:40 AM Test Summary: 72928 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4269

  3. TYPO3com commented on patch set 10 07/27/20, 08:46 Completed build in 11m 29s on Mon, 27 Jul, 08:46 AM Test Summary: 72930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4270

  4. Tizian Schmidlin uploaded patch set 12 07/27/20, 08:49

  5. TYPO3com voted on patch set 11 V +1 07/27/20, 08:53 Completed build in 16m 26s on Mon, 27 Jul, 08:53 AM Test Summary: 72930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4271

  6. TYPO3com voted on patch set 12 V +1 07/27/20, 09:03 Completed build in 13m 01s on Mon, 27 Jul, 09:03 AM Test Summary: 72930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4272

  7. Tizian Schmidlin commented on patch set 12 08/28/20, 09:31

    Hi guys, I think I'm mostly done with this BC for TYPO3 11. For what I see it should be all fine but maybe it needs some more documentation? Thanks for checking out the change, it would be great to have this change in the next major version!
  8. Tizian Schmidlin uploaded patch set 13 10/27/20, 08:00

  9. TYPO3com voted on patch set 13 V +1 10/27/20, 08:12 Completed build in 12m 10s on Tue, 27 Oct, 08:12 AM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6900

  10. Tomas Norre Mikkelsen commented on patch set 13 10/27/20, 08:30

    FileContentParser.php:837

    There is to my knowledge no need for this to be public, I would go for private or at least protected.
  11. Tizian Schmidlin commented on patch set 13 10/27/20, 08:36

    FileContentParser.php:837 Reply Unresolved

    You are probably right, although this is basically using a public Singleton I'm not sure if it really makes a difference.
  12. Tizian Schmidlin uploaded patch set 14 11/20/20, 16:37

  13. Tizian Schmidlin uploaded patch set 15 11/20/20, 16:39

  14. Tizian Schmidlin uploaded patch set 16 11/20/20, 16:57

  15. TYPO3com voted on patch set 16 V -1 11/20/20, 17:01 Completed build in 40s on Fri, 20 Nov, 05:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7490

  16. TYPO3com commented on patch set 14 11/20/20, 17:04 Completed build in 12m 59s on Fri, 20 Nov, 05:04 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7488

  17. TYPO3com commented on patch set 15 11/20/20, 17:09 Completed build in 17m 37s on Fri, 20 Nov, 05:09 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7489

  18. Tizian Schmidlin uploaded patch set 17 11/20/20, 17:13

  19. TYPO3com voted on patch set 17 V +1 11/20/20, 17:24 Completed build in 10m 50s on Fri, 20 Nov, 05:24 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7491

  20. Benni Mack uploaded patch set 18 12/04/20, 11:06

  21. TYPO3com voted on patch set 18 V +1 12/04/20, 11:15 Completed build in 08m 48s on Fri, 4 Dec, 11:15 AM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7779

  22. Benni Mack wrote 11/29/21, 10:03

    Change destination moved from master to main
  23. Benni Mack updated the commit message in patch set 19 11/29/21, 13:13

  24. Christian Kuhn commented on patch set 19 12/09/21, 00:52

    Hey. I'm going to abandon this patch for the time being, Tizian. I hope this is ok for now. There hasn't been progress in terms of reviews on this for about a year, which is sad. It seems there is currently not enough power in this area to review & finish this patch, and it also has a couple of serious merge conflicts in details that have been adapted meanwhile.= I hope it is ok to abandon this for now. If work continues in this area, we could resurrect this patch and continue, or create a fresh one. Feel free to contact us to drive things forward.
  25. Christian Kuhn abandoned the change 12/09/21, 00:52