Review 10.4 Merged

64792[BUGFIX] Fix local path discovery for external files in indexed_search

Benni Mack CR +2 V +2 Easy +1 −1 updated 06/05/20, 06:17

Commit message

This fixes encoding issues in paths with URL-encoded spaces and other
characters when indexed_search translates indexable file URLs into local
paths.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack commented on patch set 1 06/04/20, 18:33

    Cherry Picked from branch master.
  2. Jonas Eberle voted on patch set 1 V +1 CR +1 06/04/20, 18:38

  3. TYPO3com voted on patch set 1 V +1 06/04/20, 18:49 Completed build in 12m 12s on Thu, 4 Jun, 06:49 PM Test Summary: 73817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-24

  4. Benni Mack voted on patch set 1 V +2 CR +2 06/04/20, 18:51

  5. Benni Mack merged patch set 2 06/04/20, 18:51

  6. Tomas Norre Mikkelsen commented on patch set 2 06/05/20, 05:49

    I'm wondering why the forge ticket isn't update yet as it's already cherry-picked.
  7. Benni Mack commented on patch set 2 06/05/20, 06:17

    > Patch Set 2: > > I'm wondering why the forge ticket isn't update yet as it's already cherry-picked. there are some automations that I don't agree with and are buggy... however I don't know where this happens as I don't maintain any of these systems ;)