Review main Abandoned

64812[TASK] Show version number in TYPO3 installer

Josef Glatz CR 0 V 0 Easy +3 −2 updated 10/05/20, 09:37

Commit message

This patch adds the current TYPO3 version in
the <title> tag and in the main header of the
installer wizard.

This makes it easier to differentiate a TYPO3
instance from another if you have to work with
multiple versions at the same time.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1719

  1. Josef Glatz uploaded patch set 1 06/05/20, 15:44

  2. Josef Glatz commented on patch set 1 06/05/20, 15:50

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 06/05/20, 15:56 Completed build in 11m 18s on Fri, 5 Jun, 03:55 PM Test Summary: 72800 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3872

  4. Oliver Klee commented on patch set 1 CR +1 06/06/20, 10:58

    <3
  5. Georg Ringer commented on patch set 1 CR -1 06/08/20, 19:02

    typo I guess

    InstallerController.php:1054 Unresolved

    wanna change to versionNumber?
  6. Josef Glatz updated the commit message in patch set 2 06/09/20, 13:04

  7. Josef Glatz commented on patch set 2 CR -1 06/09/20, 13:12

    Reply

    Done
  8. TYPO3com voted on patch set 2 V +1 06/09/20, 13:20 Completed build in 15m 33s on Tue, 9 Jun, 01:20 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3896

  9. Jörg Bösche voted on patch set 2 V +1 CR +1 08/28/20, 10:14

  10. Andreas Kienast commented on patch set 2 CR -2 08/28/20, 13:55

    I'm blocking this patch for now. We removed the version number from public places some time ago because this exposes the exact patch level and allows to abuse affected security issues then. Additionally, how often do you install multiple TYPO3s with different versions in parallel? ;)
  11. Frank Nägler commented on patch set 2 CR -1 08/28/20, 13:58

    I see no real benefit from this patch. Also, the version number was removed from public views for security reasons: https://github.com/TYPO3/TYPO3.CMS/commit/cbb47410afb765f93cd10877a4ad4c0125fb38f3 We should avoid adding it again. An maybe I am wrong, but if you install a TYPO3 system, you should know which version you downloaded and try to install, or not? If you think I am wrong or misunderstood the patch, please ping me,
  12. Oliver Klee wrote 08/28/20, 14:35

    Removed reviewer Oliver Klee.
  13. Jörg Bösche wrote 08/31/20, 08:57

    Removed reviewer Jörg Bösche with the following votes: * Verified+1 by Jörg Bösche <typo3@joergboesche.de> * Code-Review+1 by Jörg Bösche <typo3@joergboesche.de>
  14. Christian Kuhn commented on patch set 2 09/03/20, 20:55

    Hey. I hope it's ok if I abandon this patch: I agree there we shouldn't expose the core version so directly and there seems to be no other opinion on that.
  15. Christian Kuhn abandoned the change 09/03/20, 20:55

  16. Josef Glatz commented on patch set 2 10/05/20, 09:19

    Folks, this patch was intended to show the version while the install wizard of an TYPO3 instance ¯\_(ツ)_/¯
  17. Josef Glatz commented on patch set 2 10/05/20, 09:27

    > Patch Set 2: Code-Review-2 > > I'm blocking this patch for now. We removed the version number from public places some time ago because this exposes the exact patch level and allows to abuse affected security issues then. > > Additionally, how often do you install multiple TYPO3s with different versions in parallel? ;) It's always ugly that you doesn't see the version via UI! I'm also asking kindly where this info is exposed in public?
  18. Andreas Kienast commented on patch set 2 10/05/20, 09:34

    > Patch Set 2: > > > Patch Set 2: Code-Review-2 > > > > I'm blocking this patch for now. We removed the version number from public places some time ago because this exposes the exact patch level and allows to abuse affected security issues then. > > > > Additionally, how often do you install multiple TYPO3s with different versions in parallel? ;) > > It's always ugly that you doesn't see the version via UI! I'm also asking kindly where this info is exposed in public? The installation routine is accessible via browser without a pre-defined htaccess, thus it‘s public.
  19. Josef Glatz commented on patch set 2 10/05/20, 09:37

    > Patch Set 2: > > > Patch Set 2: > > > > > Patch Set 2: Code-Review-2 > > > > > > I'm blocking this patch for now. We removed the version number from public places some time ago because this exposes the exact patch level and allows to abuse affected security issues then. > > > > > > Additionally, how often do you install multiple TYPO3s with different versions in parallel? ;) > > > > It's always ugly that you doesn't see the version via UI! I'm also asking kindly where this info is exposed in public? > The installation routine is accessible via browser without a pre-defined htaccess, thus it‘s public. A TYPO3 instance in "install mode" on a public webserver is public. of course. then it will be too late anyway :-D