Review main Merged Breaking

64833[!!!][TASK] Replace bootstrap-datetimepicker

Andreas Kienast CR +2 V +2 Expert +1072 −389 updated 10/16/20, 15:57

Commit message

This patch replaces the bootstrap-datetimepicker with flatpickr which
is pretty lightweight.

Since this datetimepicker also has some sanity validation on board, much
custom datetime parsing in FormEngine can and has been removed,
including magic date manipulation by using addition or subtraction.

The year format for momentjs has been changed from `YYYY` to `Y` as well
to support years < 1000.

Currently the datepicker is not able to select a date < 100.
By manual selection, the picker jumps back to 1999 and not to 99 as
expected.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 25

Show 5 more files

Review log 2437

Show 712 earlier messages
  1. Andreas Kienast uploaded patch set 1 06/06/20, 13:02

  2. TYPO3com voted on patch set 1 V -1 06/06/20, 13:18 Completed build in 15m 16s on Sat, 6 Jun, 01:18 PM Test Summary: 9 of 73290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3876

  3. Andreas Kienast uploaded patch set 2 06/06/20, 16:12

  4. TYPO3com voted on patch set 2 V -1 06/06/20, 16:27 Completed build in 15m 33s on Sat, 6 Jun, 04:27 PM Test Summary: 2 of 73287 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3877

  5. Andreas Kienast uploaded patch set 3 06/08/20, 07:00

  6. TYPO3com voted on patch set 3 V -1 06/08/20, 07:13 Completed build in 13m 23s on Mon, 8 Jun, 07:13 AM Test Summary: 2 of 73289 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3880

  7. Andreas Kienast uploaded patch set 4 06/08/20, 08:15

  8. TYPO3com voted on patch set 4 V +1 06/08/20, 08:29 Completed build in 13m 03s on Mon, 8 Jun, 08:29 AM Test Summary: 72800 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3882

  9. Andreas Kienast commented on patch set 4 06/08/20, 09:23

    Gruntfile.js:508 Unresolved

    We may copy l10n/index.js only which contains all localizations
  10. Andreas Kienast uploaded patch set 5 06/08/20, 21:29

  11. TYPO3com voted on patch set 5 V +1 06/08/20, 21:51 Completed build in 22m 38s on Mon, 8 Jun, 09:51 PM Test Summary: 72824 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3893

  12. Andreas Kienast uploaded patch set 6 06/10/20, 21:00

  1. TYPO3com voted on patch set 6 V +1 06/10/20, 21:12 Completed build in 12m 09s on Wed, 10 Jun, 09:12 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3902

  2. Andreas Kienast uploaded patch set 7 06/11/20, 15:51

  3. TYPO3com voted on patch set 7 V +1 06/11/20, 16:03 Completed build in 12m 34s on Thu, 11 Jun, 04:03 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3906

  4. Andreas Kienast uploaded patch set 8 06/11/20, 19:42

  5. TYPO3com voted on patch set 8 V -1 06/11/20, 19:54 Completed build in 11m 44s on Thu, 11 Jun, 07:54 PM Test Summary: 9 of 73347 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3907

  6. TYPO3com voted on patch set 8 V +1 06/11/20, 20:07 Completed build in 37m 01s on Thu, 11 Jun, 08:07 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3907

  7. Daniel Siepmann commented on patch set 8 06/16/20, 06:31

    Right now I'm not able to select a year < 100. I've recorded a video: https://tmp.daniel-siepmann.de/projects/typo3/64833-lower-100.mp4, which doesn't play in my Firefox but Chromium.
  8. Daniel Siepmann commented on patch set 8 06/16/20, 06:32

    > Patch Set 8: > > Right now I'm not able to select a year < 100. > I've recorded a video: https://tmp.daniel-siepmann.de/projects/typo3/64833-lower-100.mp4, which doesn't play in my Firefox but Chromium. The field is configured like documented at https://forge.typo3.org/issues/91508
  9. Andreas Kienast commented on patch set 8 06/21/20, 11:51

    > Patch Set 8: > > > Patch Set 8: > > > > Right now I'm not able to select a year < 100. > > I've recorded a video: https://tmp.daniel-siepmann.de/projects/typo3/64833-lower-100.mp4, which doesn't play in my Firefox but Chromium. > > The field is configured like documented at https://forge.typo3.org/issues/91508 This seems to be a limitation by the datetime picker then.
  10. Andreas Kienast abandoned the change 06/26/20, 11:11

    The issue mentioned in the commit message is a still unresolved bug in flatpickr and no new release is in sight. It seems there are no datetime pickers available fulfilling our needs. For these reasons, this patch will get abandoned now until we have a proper replacement.
  11. Benni Mack restored the change 10/15/20, 09:15

  12. Benni Mack commented on patch set 8 10/15/20, 09:15

    Looks like flatpickr picked up the issues and we can proceed here. Will update the patch soon.
  13. Michael Semle uploaded patch set 9 10/15/20, 11:21

  14. TYPO3com voted on patch set 9 V -1 10/15/20, 11:22 Completed build in 20s on Thu, 15 Oct, 11:22 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6554

  15. Benni Mack uploaded patch set 10 10/15/20, 13:01

  16. TYPO3com voted on patch set 10 V +1 10/15/20, 13:14 Completed build in 11m 59s on Thu, 15 Oct, 01:14 PM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6559

  17. Michael Semle uploaded patch set 11 10/15/20, 14:04

  18. TYPO3com voted on patch set 11 V +1 10/15/20, 14:16 Completed build in 12m 01s on Thu, 15 Oct, 02:16 PM Test Summary: 73704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6561

  19. Andreas Kienast commented on patch set 11 V +1 CR +1 10/16/20, 10:02

    Works for me so far. One minor UX aspect: if I focus an empty field, the datepicker should show the current month and year instead of January 1960.
  20. Benni Mack commented on patch set 11 10/16/20, 15:37

    > Patch Set 11: Verified+1 Code-Review+1 > > Works for me so far. > > One minor UX aspect: if I focus an empty field, the datepicker should show the current month and year instead of January 1960. cannot reproduce, Andy. But one thing I noticed: The "x" is gone. Will investigate.
  21. Benni Mack uploaded patch set 12 10/16/20, 15:43

  22. Benni Mack voted on patch set 12 V +1 CR +1 10/16/20, 15:44

  23. Andreas Kienast voted on patch set 12 V +2 CR +2 10/16/20, 15:46

  24. TYPO3com voted on patch set 12 V +1 10/16/20, 15:56 Completed build in 12m 53s on Fri, 16 Oct, 03:56 PM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6583

  25. Andreas Kienast merged patch set 13 10/16/20, 15:57