Review main Merged Breaking

64840[!!!][TASK] Remove various deprecated arguments and methods

Benni Mack CR +2 V +2 Hard +46 −225 updated 07/09/20, 12:38

Commit message

This change removes deprecated functionality:

- ReferenceIndex->updateIndex() is now either ProgressListenerInterface or null
- ExtensionManagementUtility->findService() expects an array as third argument
- BasicFileUtility->setFileExtensionPermissions() removed
- GeneralUtility->callUserFunction now expects object or null as third argument
- DataMapper->__construct does not expect $query to be set anymore
- ObjectAccess->setProperty - fourth argument removed

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 16

Review log 814

  1. Benni Mack uploaded patch set 1 06/08/20, 12:50

  2. TYPO3com voted on patch set 1 V -1 06/08/20, 12:57 Completed build in 06m 27s on Mon, 8 Jun, 12:57 PM Test Summary: 3485 of 65999 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3885

  3. Benni Mack uploaded patch set 2 06/08/20, 14:28

  4. TYPO3com voted on patch set 2 V -1 06/08/20, 14:39 Completed build in 11m 10s on Mon, 8 Jun, 02:39 PM Test Summary: 54 of 73278 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3886

  5. Benni Mack uploaded patch set 3 06/08/20, 15:00

  6. TYPO3com voted on patch set 3 V -1 06/08/20, 15:12 Completed build in 12m 07s on Mon, 8 Jun, 03:12 PM Test Summary: 72791 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3888

  7. TYPO3com commented on patch set 3 06/08/20, 15:29 Completed build in 41m 30s on Mon, 8 Jun, 03:29 PM Test Summary: 72791 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3888

  8. TYPO3com commented on patch set 3 06/08/20, 15:30 Completed build in 1h 11m 51s on Mon, 8 Jun, 03:30 PM Test Summary: 72791 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3888

  9. Benni Mack uploaded patch set 4 06/08/20, 15:46

  10. TYPO3com voted on patch set 4 V +1 06/08/20, 15:57 Completed build in 11m 06s on Mon, 8 Jun, 03:57 PM Test Summary: 72791 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3889

  11. Oliver Hader voted on patch set 4 CR +1 07/03/20, 11:38

  12. Andreas Kienast voted on patch set 4 V +1 CR +1 07/03/20, 11:54

  13. Daniel Goerz voted on patch set 4 V +2 CR +2 07/09/20, 12:38

  14. Daniel Goerz wrote 07/09/20, 12:38

    Change has been successfully rebased and submitted as eb0d45284428c3bb4b436462e8b311a6f9ddb492 by Daniel Goerz