Review main Merged

64850[BUGFIX] Use proper language label for hidden headlines in preview

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 06/14/20, 19:09

Commit message

A wrong label was used when using "Fluid based page module".
This resulted in "[]" instead of "[Hidden]" for records with hidden
headline.

This is fixed by using the proper label reference.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Daniel Siepmann uploaded patch set 1 06/10/20, 06:57

  2. TYPO3com voted on patch set 1 V +1 06/10/20, 07:09 Completed build in 11m 39s on Wed, 10 Jun, 07:09 AM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3897

  3. Guido Schmechel voted on patch set 1 CR +1 06/10/20, 08:15

  4. Josef Glatz updated the commit message in patch set 2 06/10/20, 08:22

  5. TYPO3com voted on patch set 2 V +1 06/10/20, 08:34 Completed build in 12m 10s on Wed, 10 Jun, 08:34 AM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3898

  6. Josef Glatz voted on patch set 2 CR +1 06/10/20, 09:10

  7. Josef Glatz voted on patch set 2 V +1 06/10/20, 09:11

  8. Guido Schmechel voted on patch set 2 CR +1 06/10/20, 09:20

  9. Daniel Haupt commented on patch set 2 06/10/20, 13:23

    Unresolved

    Has to be 10.4, right?
  10. Björn Jacob updated the commit message in patch set 3 06/11/20, 11:41

  11. Björn Jacob voted on patch set 3 V +1 CR +1 06/11/20, 11:42

  12. TYPO3com voted on patch set 3 V +1 06/11/20, 11:54 Completed build in 13m 29s on Thu, 11 Jun, 11:54 AM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3905

  13. Daniel Goerz voted on patch set 3 V +2 CR +2 06/14/20, 19:08

  14. Daniel Goerz merged patch set 4 06/14/20, 19:09