Review main Merged

64851[TASK] Update phpstan to at least 0.12.37

Alexander Schnitzler CR +2 V +2 Normal +146 −34 updated 09/23/20, 18:53

Commit message

Updating phpstan to version 0.12.37 lets phpstan benefit from
static reflection which does no longer come with the need to
load analyzed classes and use the native reflection api of php.
Instead, roave/better-reflection is used, which does a better
job and reduces false positives.

Since phpstan has been updated, the rules which have been copied
over from the vendor package had to be updated as well.

And since phpstan does find more errors now, a few rules had to
be disabled again.

Used commands:

    - composer require phpstan/phpstan:^0.12.37 --dev
    - composer require friendsoftypo3/phpstan-typo3:^0.4.0 --dev

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1116

  1. Alexander Schnitzler uploaded patch set 1 06/10/20, 15:13

  2. TYPO3com voted on patch set 1 V -1 06/10/20, 15:29 Completed build in 16m 00s on Wed, 10 Jun, 03:29 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3899

  3. Alexander Schnitzler uploaded patch set 2 06/10/20, 15:45

  4. Alexander Schnitzler updated the commit message in patch set 3 06/10/20, 15:52

  5. TYPO3com voted on patch set 2 V +1 06/10/20, 15:58 Completed build in 12m 27s on Wed, 10 Jun, 03:58 PM Test Summary: 72858 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3900

  6. TYPO3com voted on patch set 3 V +1 06/10/20, 16:06 Completed build in 13m 30s on Wed, 10 Jun, 04:06 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3901

  7. Oliver Klee voted on patch set 3 CR +1 06/10/20, 16:13

  8. Alexander Schnitzler wrote 06/10/20, 16:26

    Topic set to phpstan
  9. Alexander Schnitzler uploaded patch set 4 08/10/20, 08:24

  10. Alexander Schnitzler uploaded patch set 5 08/10/20, 08:25

  11. TYPO3com voted on patch set 4 V -1 08/10/20, 08:37 Completed build in 12m 28s on Mon, 10 Aug, 08:37 AM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4533

  12. TYPO3com voted on patch set 5 V +1 08/10/20, 08:39 Completed build in 13m 24s on Mon, 10 Aug, 08:39 AM Test Summary: 72971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4534

  13. Oliver Klee voted on patch set 5 CR +1 08/10/20, 11:47

  14. Benni Mack voted on patch set 5 V +2 CR +2 08/13/20, 09:46

  15. Benni Mack merged patch set 6 08/13/20, 09:46

  16. Daniel Goerz commented on patch set 6 09/23/20, 18:53

    we should backport this to keep the rulesets of our branches in sync for a better backporting experience