64873[TASK] Use absolute paths when installing extensions
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php+4 −9
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+1 −3
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+28 −27
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+1 −3
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php+5 −5
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+4 −6
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+12 −12
Review log 1320
-
Helmut Hummel uploaded patch set 1 06/11/20, 09:39
-
TYPO3com voted on patch set 1 V -1 06/11/20, 09:40 Completed build in 28s on Thu, 11 Jun, 09:40 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3903
-
Benni Mack uploaded patch set 2 12/10/20, 22:54
-
Benni Mack uploaded patch set 3 12/10/20, 22:59
-
TYPO3com voted on patch set 2 V +1 12/10/20, 23:17 Completed build in 11m 18s on Thu, 10 Dec, 11:17 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8045
-
TYPO3com voted on patch set 3 V -1 12/10/20, 23:27 Completed build in 21m 18s on Thu, 10 Dec, 11:27 PM Test Summary: 2 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8047
-
TYPO3com commented on patch set 3 12/11/20, 07:55 Completed build in 9h 10m 35s on Fri, 11 Dec, 07:55 AM Test Summary: 2 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8047
-
Benni Mack uploaded patch set 4 12/11/20, 08:03
-
Benni Mack voted on patch set 4 V +1 CR +1 12/11/20, 08:03
-
TYPO3com voted on patch set 4 V -1 12/11/20, 08:15 Completed build in 11m 57s on Fri, 11 Dec, 08:15 AM Test Summary: 31068 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8052
-
Andreas Kienast commented on patch set 4 12/11/20, 08:21
The commit message looks incomplete to me. -
TYPO3com voted on patch set 4 V +1 12/11/20, 08:42 Completed build in 51m 08s on Fri, 11 Dec, 08:42 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8052
-
Benni Mack updated the commit message in patch set 5 12/11/20, 10:17
-
Benni Mack voted on patch set 5 V +1 CR +1 12/11/20, 10:17
-
TYPO3com voted on patch set 5 V +1 12/11/20, 10:27 Completed build in 09m 13s on Fri, 11 Dec, 10:27 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8060
-
Benni Mack commented on patch set 5 12/11/20, 11:09
Reply
Ack -
Andreas Kienast voted on patch set 5 V +2 CR +2 12/11/20, 12:02
-
Andreas Kienast merged patch set 6 12/11/20, 12:03
-
Tymoteusz Motylewski commented on patch set 6 12/11/20, 13:21
Will this still work after you move TYPO3 to a different folder, or different envorinment? some paths are stored in db registry afaik. -
Benni Mack commented on patch set 6 12/11/20, 13:44
Reply Unresolved
Yes. Paths are stripped before put into registry.