Review main Merged

64873[TASK] Use absolute paths when installing extensions

Helmut Hummel CR +2 V +2 Normal +57 −67 updated 12/11/20, 13:44

Commit message

In order to prepare for further refactorings and streamlining
extension manager code, resolving extensions' path is now
always handled with a full path.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1320

  1. Helmut Hummel uploaded patch set 1 06/11/20, 09:39

  2. TYPO3com voted on patch set 1 V -1 06/11/20, 09:40 Completed build in 28s on Thu, 11 Jun, 09:40 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3903

  3. Benni Mack uploaded patch set 2 12/10/20, 22:54

  4. Benni Mack uploaded patch set 3 12/10/20, 22:59

  5. TYPO3com voted on patch set 2 V +1 12/10/20, 23:17 Completed build in 11m 18s on Thu, 10 Dec, 11:17 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8045

  6. TYPO3com voted on patch set 3 V -1 12/10/20, 23:27 Completed build in 21m 18s on Thu, 10 Dec, 11:27 PM Test Summary: 2 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8047

  7. TYPO3com commented on patch set 3 12/11/20, 07:55 Completed build in 9h 10m 35s on Fri, 11 Dec, 07:55 AM Test Summary: 2 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8047

  8. Benni Mack uploaded patch set 4 12/11/20, 08:03

  9. Benni Mack voted on patch set 4 V +1 CR +1 12/11/20, 08:03

  10. TYPO3com voted on patch set 4 V -1 12/11/20, 08:15 Completed build in 11m 57s on Fri, 11 Dec, 08:15 AM Test Summary: 31068 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8052

  11. Andreas Kienast commented on patch set 4 12/11/20, 08:21

    The commit message looks incomplete to me.
  12. TYPO3com voted on patch set 4 V +1 12/11/20, 08:42 Completed build in 51m 08s on Fri, 11 Dec, 08:42 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8052

  13. Benni Mack updated the commit message in patch set 5 12/11/20, 10:17

  14. Benni Mack voted on patch set 5 V +1 CR +1 12/11/20, 10:17

  15. TYPO3com voted on patch set 5 V +1 12/11/20, 10:27 Completed build in 09m 13s on Fri, 11 Dec, 10:27 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8060

  16. Benni Mack commented on patch set 5 12/11/20, 11:09

    Reply

    Ack
  17. Andreas Kienast voted on patch set 5 V +2 CR +2 12/11/20, 12:02

  18. Andreas Kienast merged patch set 6 12/11/20, 12:03

  19. Tymoteusz Motylewski commented on patch set 6 12/11/20, 13:21

    Will this still work after you move TYPO3 to a different folder, or different envorinment? some paths are stored in db registry afaik.
  20. Benni Mack commented on patch set 6 12/11/20, 13:44

    Reply Unresolved

    Yes. Paths are stripped before put into registry.