Review main Merged

64874[BUGFIX] Always merge results from empty tabs

Helmut Hummel CR +2 V +2 Easy +2 −3 updated 07/09/20, 12:44

Commit message

When rendering child elements of a tabs, not only
the rendered HTML is collected from these child elements,
but also hidden fields HTML, assets and a lot more.

Therefore it is crucial to merge the child results regardless
of whether the "html" property is empty.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Helmut Hummel uploaded patch set 1 06/11/20, 09:47

  2. TYPO3com voted on patch set 1 V +1 06/11/20, 09:59 Completed build in 11m 21s on Thu, 11 Jun, 09:59 AM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3904

  3. Andreas Kienast voted on patch set 1 CR +1 06/11/20, 19:10

  4. Oliver Klee updated the commit message in patch set 2 06/12/20, 11:19

  5. TYPO3com voted on patch set 2 V +1 06/12/20, 11:30 Completed build in 11m 12s on Fri, 12 Jun, 11:30 AM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3908

  6. Andreas Kienast voted on patch set 2 CR +1 06/14/20, 09:56

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 07/06/20, 11:57

  8. Benni Mack voted on patch set 2 V +2 CR +2 07/09/20, 12:44

  9. Benni Mack wrote 07/09/20, 12:44

    Change has been successfully rebased and submitted as c7b262f456bee9ae22891bbd0955a49da0ea73dc by Benni Mack