64875[BUGFIX] Restructure some event listeners
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextMenu.ts1+2 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ModuleMenu.ts+40 −42
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Toolbar.ts1+14 −27
- typo3/sysext/backend/Classes/Controller/BackendController.php+0 −1
- typo3/sysext/backend/Resources/Private/Templates/ModuleMenu/Main.html+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ModuleMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Toolbar.js+1 −1
Review log 1419
-
Andreas Kienast uploaded patch set 1 06/12/20, 22:22
-
Andreas Kienast updated the commit message in patch set 2 06/12/20, 22:24
-
TYPO3com voted on patch set 1 V -1 06/12/20, 22:37 Completed build in 15m 03s on Fri, 12 Jun, 10:37 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3909
-
TYPO3com voted on patch set 2 V -1 06/12/20, 22:44 Completed build in 16m 46s on Fri, 12 Jun, 10:44 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3910
-
Andreas Kienast uploaded patch set 3 06/13/20, 05:12
-
TYPO3com voted on patch set 3 V +1 06/13/20, 05:26 Completed build in 13m 40s on Sat, 13 Jun, 05:26 AM Test Summary: 72859 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3911
-
Andreas Kienast wrote 06/27/20, 09:39
Topic set to javascript -
Anja Leichsenring commented on patch set 3 V +1 CR +1 06/27/20, 10:01
I only tested by clicking around in the backend with focus on toolbar and module menu, also in mobile view. Hope this is enough. -
Oliver Hader commented on patch set 3 CR +1 06/28/20, 07:43
ContextMenu.ts:120UnresolvedAlbeit it's not required right now, please preserve the scope `this.storeMousePositionEvent.bind(this)` -
Andreas Kienast uploaded patch set 4 06/28/20, 09:24
-
TYPO3com voted on patch set 4 V +1 06/28/20, 09:41 Completed build in 16m 26s on Sun, 28 Jun, 09:41 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4004
-
Markus Klein commented on patch set 4 06/29/20, 07:20
Could we maybe backport the mouse position lookup change to v10 as well?Toolbar.ts:44UnresolvedNo need for this extra arrow function: DocumentService.ready().then(Toolbar.initialize); -
Andreas Kienast commented on patch set 4 06/29/20, 07:41
> Patch Set 4: > > (1 comment) > > Could we maybe backport the mouse position lookup change to v10 as well? What would it be good for? Performance considerations only? -
Markus Klein commented on patch set 4 06/29/20, 07:51
> Patch Set 4: > > > Patch Set 4: > > > > (1 comment) > > > > Could we maybe backport the mouse position lookup change to v10 as well? > > What would it be good for? Performance considerations only? CPU usage of the browser, would be my guess? -
Andreas Kienast uploaded patch set 5 06/30/20, 06:14
-
TYPO3com voted on patch set 5 V +1 06/30/20, 06:26 Completed build in 11m 38s on Tue, 30 Jun, 06:26 AM Test Summary: 72866 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4022
-
Christian Kuhn voted on patch set 5 V +1 CR +1 07/30/20, 20:09
-
Anja Leichsenring voted on patch set 5 V +2 CR +2 07/30/20, 20:54
-
Anja Leichsenring merged patch set 6 07/30/20, 20:54