Review main Merged

64875[BUGFIX] Restructure some event listeners

Andreas Kienast CR +2 V +2 Normal +60 −75 updated 07/30/20, 20:54

Commit message

To improve the event handling in the browsers, events that don't need to
listen to `document` have been restructured to listen either directly on
an element or to their respective nearest common element instead.

To increase UX, an event listener has been removed from Topbar which
closes the whole overlay when closing a sub menu in mobile view.
Another, redundant event listener has been removed as well.

As a drive-by bugfix the mouse cursor position used for context menus is
now fetched and stored every 50ms only. In a later iteration this
behavior may change completely.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1419

  1. Andreas Kienast uploaded patch set 1 06/12/20, 22:22

  2. Andreas Kienast updated the commit message in patch set 2 06/12/20, 22:24

  3. TYPO3com voted on patch set 1 V -1 06/12/20, 22:37 Completed build in 15m 03s on Fri, 12 Jun, 10:37 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3909

  4. TYPO3com voted on patch set 2 V -1 06/12/20, 22:44 Completed build in 16m 46s on Fri, 12 Jun, 10:44 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3910

  5. Andreas Kienast uploaded patch set 3 06/13/20, 05:12

  6. TYPO3com voted on patch set 3 V +1 06/13/20, 05:26 Completed build in 13m 40s on Sat, 13 Jun, 05:26 AM Test Summary: 72859 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3911

  7. Andreas Kienast wrote 06/27/20, 09:39

    Topic set to javascript
  8. Anja Leichsenring commented on patch set 3 V +1 CR +1 06/27/20, 10:01

    I only tested by clicking around in the backend with focus on toolbar and module menu, also in mobile view. Hope this is enough.
  9. Oliver Hader commented on patch set 3 CR +1 06/28/20, 07:43

    ContextMenu.ts:120 Unresolved

    Albeit it's not required right now, please preserve the scope `this.storeMousePositionEvent.bind(this)`
  10. Andreas Kienast uploaded patch set 4 06/28/20, 09:24

  11. TYPO3com voted on patch set 4 V +1 06/28/20, 09:41 Completed build in 16m 26s on Sun, 28 Jun, 09:41 AM Test Summary: 72863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4004

  12. Markus Klein commented on patch set 4 06/29/20, 07:20

    Could we maybe backport the mouse position lookup change to v10 as well?

    Toolbar.ts:44 Unresolved

    No need for this extra arrow function: DocumentService.ready().then(Toolbar.initialize);
  13. Andreas Kienast commented on patch set 4 06/29/20, 07:41

    > Patch Set 4: > > (1 comment) > > Could we maybe backport the mouse position lookup change to v10 as well? What would it be good for? Performance considerations only?
  14. Markus Klein commented on patch set 4 06/29/20, 07:51

    > Patch Set 4: > > > Patch Set 4: > > > > (1 comment) > > > > Could we maybe backport the mouse position lookup change to v10 as well? > > What would it be good for? Performance considerations only? CPU usage of the browser, would be my guess?
  15. Andreas Kienast uploaded patch set 5 06/30/20, 06:14

  16. TYPO3com voted on patch set 5 V +1 06/30/20, 06:26 Completed build in 11m 38s on Tue, 30 Jun, 06:26 AM Test Summary: 72866 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4022

  17. Christian Kuhn voted on patch set 5 V +1 CR +1 07/30/20, 20:09

  18. Anja Leichsenring voted on patch set 5 V +2 CR +2 07/30/20, 20:54

  19. Anja Leichsenring merged patch set 6 07/30/20, 20:54