64897[BUGFIX] Only add JSlibs once in PageRenderer
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Siepmann +1
-
Verified V +2 Done
- Benni Mack +2
- TYPO3com +1 CI
Issues 1
Files 1
Review log 79
-
Markus Klein uploaded patch set 1 06/16/20, 11:22
-
Daniel Siepmann voted on patch set 1 CR +1 06/16/20, 11:25
-
Jonas Eberle commented on patch set 1 06/16/20, 11:39
This prevents overwritability of a previously registered library. IMHO the condition, although once intended, is unwanted now and overwriting has become the living standard. AssetCollector does unconditional overrides https://github.com/TYPO3/TYPO3.CMS/blob/7b919798c8784ba3a3dd8cb82ab2d8a7e777878a/typo3/sysext/core/Classes/Page/AssetCollector.php#L83 I suggest to not change behaviour (by removing the condition). If changed it is breaking. -
TYPO3com voted on patch set 1 V -1 06/16/20, 11:41 Completed build in 18m 58s on Tue, 16 Jun, 11:41 AM Test Summary: 72524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3919
-
TYPO3com voted on patch set 1 V +1 06/16/20, 19:53 Completed build in 13m 57s on Tue, 16 Jun, 07:53 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3934
-
Benni Mack voted on patch set 1 V +2 CR +2 08/05/20, 15:29
-
Benni Mack merged patch set 2 08/05/20, 15:29
-
Benni Mack commented on patch set 2 08/06/20, 09:08
Crap, Jonas, didn't see your remark. @Markus what do you suggest? The solution would be then to remove the if completely? -
Markus Klein commented on patch set 2 08/06/20, 12:37
> Patch Set 2: > > Crap, Jonas, didn't see your remark. @Markus what do you suggest? The solution would be then to remove the if completely? Well, as I said, the API in PageRenderer should be consistent. Every bugfix is sort of a breaking change. The initial intention is clear from the code. The new API in the AssetCollector may work differently, but this is perfectly fine. Hence, I would still keep the change as it is.