64898[TASK] Use $cObj->stdWrapValue where possible
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 16
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+14 −53
- typo3/sysext/frontend/Classes/ContentObject/Menu/CategoryMenuUtility.php+3 −11
- typo3/sysext/frontend/Classes/ContentObject/Menu/TextMenuContentObject.php+11 −14
- typo3/sysext/frontend/Classes/ContentObject/CaseContentObject.php+2 −4
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+7 −10
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectArrayContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php+5 −24
- typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php+11 −29
- typo3/sysext/frontend/Classes/ContentObject/HierarchicalMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php+14 −38
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+6 −6
- typo3/sysext/frontend/Classes/ContentObject/ScalableVectorGraphicsContentObject.php+5 −7
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+29 −5
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+10 −4
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php1+156 −88
Review log 1628
Show 23 earlier messages
-
Nikita Hovratov uploaded patch set 1 06/16/20, 14:04
-
TYPO3com voted on patch set 1 V -1 06/16/20, 14:18 Completed build in 13m 51s on Tue, 16 Jun, 02:18 PM Test Summary: 3683 of 73347 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3920
-
Nikita Hovratov uploaded patch set 2 06/16/20, 14:55
-
TYPO3com voted on patch set 2 V -1 06/16/20, 15:07 Completed build in 12m 30s on Tue, 16 Jun, 03:07 PM Test Summary: 2273 of 73347 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3922
-
Nikita Hovratov uploaded patch set 3 06/16/20, 15:13
-
TYPO3com voted on patch set 3 V -1 06/16/20, 15:25 Completed build in 12m 04s on Tue, 16 Jun, 03:25 PM Test Summary: 180 of 73347 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3924
-
Nikita Hovratov uploaded patch set 4 06/16/20, 16:10
-
TYPO3com voted on patch set 4 V -1 06/16/20, 16:30 Completed build in 19m 51s on Tue, 16 Jun, 04:30 PM Test Summary: 48 of 73347 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3928
-
Nikita Hovratov uploaded patch set 5 06/16/20, 17:13
-
TYPO3com voted on patch set 5 V -1 06/16/20, 17:27 Completed build in 13m 52s on Tue, 16 Jun, 05:27 PM Test Summary: 66779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3929
-
Nikita Hovratov uploaded patch set 6 06/16/20, 17:31
-
TYPO3com voted on patch set 6 V -1 06/16/20, 17:45 Completed build in 13m 53s on Tue, 16 Jun, 05:45 PM Test Summary: 66463 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3931
-
Nikita Hovratov uploaded patch set 7 06/16/20, 18:03
-
TYPO3com voted on patch set 7 V -1 06/16/20, 18:15 Completed build in 11m 52s on Tue, 16 Jun, 06:15 PM Test Summary: 11 of 73347 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3932
-
TYPO3com voted on patch set 7 V +1 06/16/20, 19:03 Completed build in 11m 38s on Tue, 16 Jun, 07:03 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3933
-
TYPO3com commented on patch set 7 06/16/20, 19:55 Completed build in 2h 03m 36s on Tue, 16 Jun, 07:55 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3932
-
Christian Kuhn commented on patch set 7 07/20/20, 11:13
Thanks for the patch. Looks good, I'm only working on details. Will try to push another patch set soon since especially the change to the accessible mock in tests can be done in a more clean way.FluidTemplateContentObjectTest.php:67Unresolvedaccessible mocks should only be used for the subject but never for dependencies. Your change takes care that stdWrap is mocked, but not stdWrapValue (which calls stdWrap), so the existing expectations for stdWrap() can be kept. It would be better to stick with the default getMockBuilder here and adapt the tests to expect a call on eg. stdWrapValue() before (for instance from setFormat()) the 'expectation you are looking for' is expected. I'll try to come up with an adaption. Sidenote: It would be even better to switch this test case from mockBuilder to prophecy which does not allow stuff like accessible mocks in the first place. This however should be a different patch. -
Christian Kuhn uploaded patch set 8 07/20/20, 13:30
-
TYPO3com voted on patch set 8 V +1 07/20/20, 13:41 Completed build in 11m 18s on Mon, 20 Jul, 01:41 PM Test Summary: 72945 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4157
-
Christian Kuhn uploaded patch set 9 07/20/20, 16:56
-
Christian Kuhn commented on patch set 9 07/20/20, 17:01
There is an edge case that sometimes the former calls lead to null if something like $foo['bar'] is not set at all. The stdWrapValue() changes this to empty string as default value. I went through all hunks and added a couple of 'null' default values for stdWrapValue() where it is not obvious that using code does not differentiate between empty string and null. -
TYPO3com voted on patch set 9 V -1 07/20/20, 17:11 Completed build in 14m 24s on Mon, 20 Jul, 05:11 PM Test Summary: 6 of 73438 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4162
-
Christian Kuhn commented on patch set 9 CR -1 07/20/20, 17:14
hmpf, my bad ... will take care of the failing tests tomorrow ;) -
Christian Kuhn uploaded patch set 10 07/21/20, 08:23
-
Christian Kuhn voted on patch set 10 V +1 CR +1 07/21/20, 08:26
-
TYPO3com voted on patch set 10 V +1 07/21/20, 08:34 Completed build in 11m 35s on Tue, 21 Jul, 08:34 AM Test Summary: 72951 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4168
-
Benni Mack voted on patch set 10 V +2 CR +2 07/21/20, 09:58
-
Benni Mack merged patch set 11 07/21/20, 09:58